github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10166] [MERGED] types: add any type and validation for ToolFunction enum #13163

New Issue
Closed
opened 2026-04-13 00:19:26 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:19:26 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10166
Author: @ParthSareen
Created: 4/7/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @ParthSareen

Base: main ← Head: parth/10164-relax-tool-schema-enum

📝 Commits (2)

  • 439d764 types: add any type and validation for ToolFunction enum
  • 585aea8 remove unnecessary validation for toolfunction

📊 Changes

4 files changed (+71 additions, -10 deletions)

View changed files

📝 api/types.go (+1 -1)
📝 api/types_test.go (+61 -0)
📝 openai/openai_test.go (+3 -3)
📝 server/routes_generate_test.go (+6 -6)

📄 Description

Closes: https://github.com/ollama/ollama/issues/10164

Given the spec: https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-01#section-6.1.2

We should allow for any enum type as long as they are consistent and unique

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10166 **Author:** [@ParthSareen](https://github.com/ParthSareen) **Created:** 4/7/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@ParthSareen](https://github.com/ParthSareen) **Base:** `main` ← **Head:** `parth/10164-relax-tool-schema-enum` --- ### 📝 Commits (2) - [`439d764`](https://github.com/ollama/ollama/commit/439d76484e939ebfce9c670e7897cc373d30f3de) types: add any type and validation for ToolFunction enum - [`585aea8`](https://github.com/ollama/ollama/commit/585aea86e1a1cfa4890f8fa959e6f7ca9118daf8) remove unnecessary validation for toolfunction ### 📊 Changes **4 files changed** (+71 additions, -10 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+1 -1) 📝 `api/types_test.go` (+61 -0) 📝 `openai/openai_test.go` (+3 -3) 📝 `server/routes_generate_test.go` (+6 -6) </details> ### 📄 Description Closes: https://github.com/ollama/ollama/issues/10164 Given the spec: https://json-schema.org/draft/2020-12/draft-bhutton-json-schema-validation-01#section-6.1.2 We should allow for any enum type as long as they are consistent and unique --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:19:26 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13163
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?