github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 16:40:08 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #10070] [MERGED] fix(integration): move waitgroup Add(1) outside goroutine to avoid potential issue #13139

New Issue
Closed
opened 2026-04-13 00:18:56 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:18:56 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/10070
Author: @googs1025
Created: 4/1/2025
Status: ✅ Merged
Merged: 4/8/2025
Merged by: @mxyng

Base: main ← Head: fix/integration_TestMaxQueue

📝 Commits (1)

  • 89073a1 fix(integration): move waitgroup Add(1) outside goroutine to avoid potential issue

📊 Changes

1 file changed (+2 additions, -2 deletions)

View changed files

📝 integration/max_queue_test.go (+2 -2)

📄 Description

Detailed description:

  • Moved waitgroup.Add(1) out of the goroutine to ensure the WaitGroup counter is properly set before any goroutine starts.
  • Prevents potential issues where waitgroup.Wait() might return prematurely due to scheduling delays.
  • Aligns with best practices for using sync.WaitGroup.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/10070 **Author:** [@googs1025](https://github.com/googs1025) **Created:** 4/1/2025 **Status:** ✅ Merged **Merged:** 4/8/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `fix/integration_TestMaxQueue` --- ### 📝 Commits (1) - [`89073a1`](https://github.com/ollama/ollama/commit/89073a182f897363fe7545af6f00be8cead390c3) fix(integration): move waitgroup Add(1) outside goroutine to avoid potential issue ### 📊 Changes **1 file changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `integration/max_queue_test.go` (+2 -2) </details> ### 📄 Description Detailed description: - Moved waitgroup.Add(1) out of the goroutine to ensure the WaitGroup counter is properly set before any goroutine starts. - Prevents potential issues where waitgroup.Wait() might return prematurely due to scheduling delays. - Aligns with best practices for using sync.WaitGroup. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:18:56 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13139
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?