github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #9873] [MERGED] fs: move ml.Config to fs package #13078

New Issue
Closed
opened 2026-04-13 00:17:20 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:17:20 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9873
Author: @mxyng
Created: 3/18/2025
Status: ✅ Merged
Merged: 4/3/2025
Merged by: @mxyng

Base: main ← Head: mxyng/fs-config

📝 Commits (1)

  • 3b96a93 fs: move ml.Config to fs package

📊 Changes

16 files changed (+55 additions, -40 deletions)

View changed files

➕ fs/config.go (+13 -0)
📝 kvcache/causal_test.go (+2 -1)
📝 ml/backend.go (+3 -13)
📝 ml/backend/ggml/ggml.go (+6 -5)
📝 model/model.go (+6 -5)
📝 model/model_test.go (+5 -4)
📝 model/models/gemma2/model.go (+2 -1)
📝 model/models/gemma3/model.go (+2 -1)
📝 model/models/gemma3/model_text.go (+2 -1)
📝 model/models/gemma3/model_vision.go (+2 -1)
📝 model/models/gemma3/process_image.go (+2 -2)
📝 model/models/llama/model.go (+2 -1)
📝 model/models/mllama/model.go (+2 -1)
📝 model/models/mllama/model_text.go (+2 -1)
📝 model/models/mllama/model_vision.go (+2 -1)
📝 model/models/mllama/process_image.go (+2 -2)

📄 Description

move the Config interface from ml to fs since it is more representative of the on-disk metadata than the runtime model

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9873 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 3/18/2025 **Status:** ✅ Merged **Merged:** 4/3/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/fs-config` --- ### 📝 Commits (1) - [`3b96a93`](https://github.com/ollama/ollama/commit/3b96a93672377129f2a2aafc447e79ef1ca48c5f) fs: move ml.Config to fs package ### 📊 Changes **16 files changed** (+55 additions, -40 deletions) <details> <summary>View changed files</summary> ➕ `fs/config.go` (+13 -0) 📝 `kvcache/causal_test.go` (+2 -1) 📝 `ml/backend.go` (+3 -13) 📝 `ml/backend/ggml/ggml.go` (+6 -5) 📝 `model/model.go` (+6 -5) 📝 `model/model_test.go` (+5 -4) 📝 `model/models/gemma2/model.go` (+2 -1) 📝 `model/models/gemma3/model.go` (+2 -1) 📝 `model/models/gemma3/model_text.go` (+2 -1) 📝 `model/models/gemma3/model_vision.go` (+2 -1) 📝 `model/models/gemma3/process_image.go` (+2 -2) 📝 `model/models/llama/model.go` (+2 -1) 📝 `model/models/mllama/model.go` (+2 -1) 📝 `model/models/mllama/model_text.go` (+2 -1) 📝 `model/models/mllama/model_vision.go` (+2 -1) 📝 `model/models/mllama/process_image.go` (+2 -2) </details> ### 📄 Description move the `Config` interface from `ml` to `fs` since it is more representative of the on-disk metadata than the runtime model --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:17:20 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13078
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?