[PR #9755] [MERGED] server/internal/chunks: remove chunks package #13054

Closed
opened 2026-04-13 00:16:35 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9755
Author: @bmizerany
Created: 3/14/2025
Status: Merged
Merged: 3/14/2025
Merged by: @bmizerany

Base: mainHead: bmizerany/rmchunkspkg


📝 Commits (1)

  • b029fd7 server/internal/chunks: remove chunks package

📊 Changes

7 files changed (+32 additions, -321 deletions)

View changed files

📝 server/internal/cache/blob/chunked.go (+10 -3)
server/internal/chunks/chunks.go (+0 -81)
server/internal/chunks/chunks_test.go (+0 -65)
📝 server/internal/client/ollama/registry.go (+22 -3)
📝 server/internal/client/ollama/registry_test.go (+0 -51)
server/internal/cmd/oppbench/oppbench.go (+0 -11)
server/internal/cmd/oppbench/oppbench_test.go (+0 -107)

📄 Description

The new chunksums API has obsoleted the need for the chunks package. The
few utilities that were useful have been swept into the packages most
appropriate for their use, and the package has been removed.

Also, remove the oppbench command, which required updates to accommodate
these changes. It was only used prove Ahmdal's law to some colleagues.
They are sold now, so it can go.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9755 **Author:** [@bmizerany](https://github.com/bmizerany) **Created:** 3/14/2025 **Status:** ✅ Merged **Merged:** 3/14/2025 **Merged by:** [@bmizerany](https://github.com/bmizerany) **Base:** `main` ← **Head:** `bmizerany/rmchunkspkg` --- ### 📝 Commits (1) - [`b029fd7`](https://github.com/ollama/ollama/commit/b029fd79ccc8f0ed7d39a08be7c97fd224d4bd83) server/internal/chunks: remove chunks package ### 📊 Changes **7 files changed** (+32 additions, -321 deletions) <details> <summary>View changed files</summary> 📝 `server/internal/cache/blob/chunked.go` (+10 -3) ➖ `server/internal/chunks/chunks.go` (+0 -81) ➖ `server/internal/chunks/chunks_test.go` (+0 -65) 📝 `server/internal/client/ollama/registry.go` (+22 -3) 📝 `server/internal/client/ollama/registry_test.go` (+0 -51) ➖ `server/internal/cmd/oppbench/oppbench.go` (+0 -11) ➖ `server/internal/cmd/oppbench/oppbench_test.go` (+0 -107) </details> ### 📄 Description The new chunksums API has obsoleted the need for the chunks package. The few utilities that were useful have been swept into the packages most appropriate for their use, and the package has been removed. Also, remove the oppbench command, which required updates to accommodate these changes. It was only used prove Ahmdal's law to some colleagues. They are sold now, so it can go. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:16:35 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#13054