github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-21 21:21:57 -05:00
Code Issues 16.9k Packages Projects Releases 122 Wiki Activity

[PR #9089] [MERGED] llm: attempt to evaluate symlinks for os.Executable, but do not fail #12856

New Issue
Closed
opened 2026-04-13 00:11:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:11:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/9089
Author: @jmorganca
Created: 2/14/2025
Status: ✅ Merged
Merged: 2/14/2025
Merged by: @jmorganca

Base: main ← Head: jmorganca/attemp-eval

📝 Commits (1)

  • a4a455d llm: attempt to evaluate symlinks, but do not fail

📊 Changes

2 files changed (+8 additions, -0 deletions)

View changed files

📝 discover/path.go (+4 -0)
📝 llm/server.go (+4 -0)

📄 Description

This PR provides a better approach to https://github.com/ollama/ollama/pull/9088 that will attempt to evaluate symlinks (important for macOS where ollama is often a symlink), but use the result of os.Executable() as a fallback in scenarios where filepath.EvalSymlinks fails due to permission errors.

Fixes https://github.com/ollama/ollama/issues/9082

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/9089 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 2/14/2025 **Status:** ✅ Merged **Merged:** 2/14/2025 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `jmorganca/attemp-eval` --- ### 📝 Commits (1) - [`a4a455d`](https://github.com/ollama/ollama/commit/a4a455dbf3b4248ad5b28f96f28ce1537adae609) llm: attempt to evaluate symlinks, but do not fail ### 📊 Changes **2 files changed** (+8 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `discover/path.go` (+4 -0) 📝 `llm/server.go` (+4 -0) </details> ### 📄 Description This PR provides a better approach to https://github.com/ollama/ollama/pull/9088 that will attempt to evaluate symlinks (important for macOS where `ollama` is often a symlink), but use the result of `os.Executable()` as a fallback in scenarios where `filepath.EvalSymlinks` fails due to permission errors. Fixes https://github.com/ollama/ollama/issues/9082 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:11:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#12856
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?