github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 08:59:13 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8996] [MERGED] api: document client stream behavior with a test #12834

New Issue
Closed
opened 2026-04-13 00:10:50 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:10:50 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8996
Author: @BruceMacD
Created: 2/10/2025
Status: ✅ Merged
Merged: 2/20/2025
Merged by: @BruceMacD

Base: main ← Head: brucemacd/client-stream

📝 Commits (2)

  • cf914aa api: document client stream behavior with a test
  • 67b42a2 test case feedback

📊 Changes

2 files changed (+211 additions, -1 deletions)

View changed files

📝 api/client.go (+1 -1)
📝 api/client_test.go (+210 -0)

📄 Description

Added unit tests to verify error handling behavior in the Client.stream method. Tests cover various error scenarios including:

  • Error responses with status codes >= 400
  • Error messages with successful status codes
  • Empty error messages
  • Successful responses

Also modified error handling order in stream() to check HTTP status code before error message, ensuring consistent behavior with StatusError type.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8996 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 2/10/2025 **Status:** ✅ Merged **Merged:** 2/20/2025 **Merged by:** [@BruceMacD](https://github.com/BruceMacD) **Base:** `main` ← **Head:** `brucemacd/client-stream` --- ### 📝 Commits (2) - [`cf914aa`](https://github.com/ollama/ollama/commit/cf914aa406341a3b658841161c5792c7f0fcdaad) api: document client stream behavior with a test - [`67b42a2`](https://github.com/ollama/ollama/commit/67b42a2aea2219200db271b79ec89ae76da07441) test case feedback ### 📊 Changes **2 files changed** (+211 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `api/client.go` (+1 -1) 📝 `api/client_test.go` (+210 -0) </details> ### 📄 Description Added unit tests to verify error handling behavior in the Client.stream method. Tests cover various error scenarios including: - Error responses with status codes >= 400 - Error messages with successful status codes - Empty error messages - Successful responses Also modified error handling order in stream() to check HTTP status code before error message, ensuring consistent behavior with StatusError type. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:10:50 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#12834
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?