github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #8190] [CLOSED] macos: detect potential version skew #12656

New Issue
Closed
opened 2026-04-13 00:06:07 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:06:07 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/8190
Author: @dhiltgen
Created: 12/20/2024
Status: ❌ Closed

Base: main ← Head: harden_mac_upgrade

📝 Commits (1)

  • 93c7330 macos: detect potential version skew

📊 Changes

1 file changed (+35 additions, -0 deletions)

View changed files

📝 llm/server.go (+35 -0)

📄 Description

During upgrade, we could get into a scenario where an old serve tries to start newer runner executables, which could have new expectations. This added check will handle non-zero exit status from the runner and double check the current process has the same version as the executable on disk. If the version has skewed, exit the serve process so the app can respawn the new binary.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/8190 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 12/20/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `harden_mac_upgrade` --- ### 📝 Commits (1) - [`93c7330`](https://github.com/ollama/ollama/commit/93c7330ffc7e4e8772c4d2cf3cf8fcdeb35629df) macos: detect potential version skew ### 📊 Changes **1 file changed** (+35 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `llm/server.go` (+35 -0) </details> ### 📄 Description During upgrade, we could get into a scenario where an old serve tries to start newer runner executables, which could have new expectations. This added check will handle non-zero exit status from the runner and double check the current process has the same version as the executable on disk. If the version has skewed, exit the serve process so the app can respawn the new binary. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:06:07 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#12656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?