github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #7964] Fix message truncation logic and ensure at least one system message i… #12574

New Issue
Open
opened 2026-04-13 00:03:37 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-13 00:03:37 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/7964
Author: @youyou301
Created: 12/6/2024
Status: 🔄 Open

Base: main ← Head: feature/fix-message-truncation

📝 Commits (1)

  • 318a0ce Fix message truncation logic and ensure at least one system message is included

📊 Changes

2 files changed (+19 additions, -3 deletions)

View changed files

📝 server/prompt.go (+7 -3)
📝 server/prompt_test.go (+12 -0)

📄 Description

Changes:

  • Fixed the message truncation logic to ensure that at least one system message is included.
  • Adjusted the message handling to always include the last message, even if the context window is exceeded.

Motivation:

  • This change ensures that the context window truncation logic respects the system messages and guarantees that at least one system message is always included in the prompt.

Related Issue(s):

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/7964 **Author:** [@youyou301](https://github.com/youyou301) **Created:** 12/6/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `feature/fix-message-truncation` --- ### 📝 Commits (1) - [`318a0ce`](https://github.com/ollama/ollama/commit/318a0ceaeff6c99d8335f9de96dd34dca3c00b38) Fix message truncation logic and ensure at least one system message is included ### 📊 Changes **2 files changed** (+19 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `server/prompt.go` (+7 -3) 📝 `server/prompt_test.go` (+12 -0) </details> ### 📄 Description ### Changes: - Fixed the message truncation logic to ensure that at least one `system` message is included. - Adjusted the message handling to always include the last message, even if the context window is exceeded. ### Motivation: - This change ensures that the context window truncation logic respects the system messages and guarantees that at least one `system` message is always included in the prompt. ### Related Issue(s): - https://github.com/ollama/ollama/issues/6176 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-13 00:03:37 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#12574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?