[PR #6483] [MERGED] gpu: Group GPU Library sets by variant #12124

Closed
opened 2026-04-12 23:50:07 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/6483
Author: @dhiltgen
Created: 8/23/2024
Status: Merged
Merged: 8/23/2024
Merged by: @dhiltgen

Base: mainHead: multi_gpu_variant


📝 Commits (1)

  • 25d59b9 gpu: Group GPU Library sets by variant

📊 Changes

2 files changed (+26 additions, -1 deletions)

View changed files

📝 gpu/gpu_test.go (+25 -0)
📝 gpu/types.go (+1 -1)

📄 Description

The recent cuda variant changes uncovered a bug in ByLibrary which failed to group by common variant for GPU types.

New unit test fails without the 1 line fix, and passes with.

Fixes #6479


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/6483 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 8/23/2024 **Status:** ✅ Merged **Merged:** 8/23/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `multi_gpu_variant` --- ### 📝 Commits (1) - [`25d59b9`](https://github.com/ollama/ollama/commit/25d59b9856141e2ed9915138b91e401e5fcfa4a6) gpu: Group GPU Library sets by variant ### 📊 Changes **2 files changed** (+26 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `gpu/gpu_test.go` (+25 -0) 📝 `gpu/types.go` (+1 -1) </details> ### 📄 Description The recent cuda variant changes uncovered a bug in ByLibrary which failed to group by common variant for GPU types. New unit test fails without the 1 line fix, and passes with. Fixes #6479 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:50:07 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#12124