[PR #5856] template: disable func checking #11944

Open
opened 2026-04-12 23:43:15 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5856
Author: @mxyng
Created: 7/22/2024
Status: 🔄 Open

Base: mainHead: mxyng/func-checks


📝 Commits (2)

  • aac17d5 template: disable func checking
  • 5bcad12 test: update undefined function test

📊 Changes

4 files changed (+58 additions, -26 deletions)

View changed files

📝 server/model.go (+2 -2)
📝 server/routes_create_test.go (+2 -2)
📝 template/template.go (+25 -20)
📝 template/template_test.go (+29 -2)

📄 Description

func checking will return error during parsing if a function is undefined even if it doesn't end up being used. disabling this enables additional functions to be defined in the future without breaking older versions assuming the function usage is properly guarded


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5856 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 7/22/2024 **Status:** 🔄 Open **Base:** `main` ← **Head:** `mxyng/func-checks` --- ### 📝 Commits (2) - [`aac17d5`](https://github.com/ollama/ollama/commit/aac17d5f158d5ba6e3b22dae9752f19d6f002cdc) template: disable func checking - [`5bcad12`](https://github.com/ollama/ollama/commit/5bcad12cd40a4b600cc43867280f4485e5dcc486) test: update undefined function test ### 📊 Changes **4 files changed** (+58 additions, -26 deletions) <details> <summary>View changed files</summary> 📝 `server/model.go` (+2 -2) 📝 `server/routes_create_test.go` (+2 -2) 📝 `template/template.go` (+25 -20) 📝 `template/template_test.go` (+29 -2) </details> ### 📄 Description func checking will return error during parsing if a function is undefined even if it doesn't end up being used. disabling this enables additional functions to be defined in the future without breaking older versions assuming the function usage is properly guarded --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:43:15 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11944