[PR #5815] [MERGED] Adjust windows ROCm discovery #11931

Closed
opened 2026-04-12 23:42:54 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5815
Author: @dhiltgen
Created: 7/20/2024
Status: Merged
Merged: 7/20/2024
Merged by: @dhiltgen

Base: mainHead: win_rocm_gfx_features


📝 Commits (1)

  • 283948c Adjust windows ROCm discovery

📊 Changes

5 files changed (+21 additions, -6 deletions)

View changed files

📝 docs/gpu.md (+13 -2)
📝 gpu/amd_hip_windows.go (+3 -2)
📝 gpu/amd_windows.go (+2 -1)
📝 llm/generate/gen_windows.ps1 (+1 -1)
📝 llm/server.go (+2 -0)

📄 Description

The v5 hip library returns unsupported GPUs which wont enumerate at inference time in the runner so this makes sure we align discovery. The gfx906 cards are no longer supported so we shouldn't compile with that GPU type as it wont enumerate at runtime.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5815 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 7/20/2024 **Status:** ✅ Merged **Merged:** 7/20/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `win_rocm_gfx_features` --- ### 📝 Commits (1) - [`283948c`](https://github.com/ollama/ollama/commit/283948c83b5cbf74f6cf86dce4434238e64d6e1c) Adjust windows ROCm discovery ### 📊 Changes **5 files changed** (+21 additions, -6 deletions) <details> <summary>View changed files</summary> 📝 `docs/gpu.md` (+13 -2) 📝 `gpu/amd_hip_windows.go` (+3 -2) 📝 `gpu/amd_windows.go` (+2 -1) 📝 `llm/generate/gen_windows.ps1` (+1 -1) 📝 `llm/server.go` (+2 -0) </details> ### 📄 Description The v5 hip library returns unsupported GPUs which wont enumerate at inference time in the runner so this makes sure we align discovery. The gfx906 cards are no longer supported so we shouldn't compile with that GPU type as it wont enumerate at runtime. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:42:54 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11931