github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #5713] [MERGED] server: return empty slice on empty /api/embed request #11897

New Issue
Closed
opened 2026-04-12 23:42:04 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:42:04 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5713
Author: @jmorganca
Created: 7/16/2024
Status: ✅ Merged
Merged: 7/16/2024
Merged by: @jmorganca

Base: main ← Head: jmorganca/embed

📝 Commits (2)

  • 2f3f1f8 server: return empty slice on empty /api/embed request
  • 67ae410 fix tests

📊 Changes

2 files changed (+7 additions, -3 deletions)

View changed files

📝 api/types.go (+1 -1)
📝 server/routes_test.go (+6 -2)

📄 Description

Before:

curl http://localhost:11434/api/embed \                                 
  -H "Content-Type: application/json" \
  -d '{
    "input": "",
    "model": "all-minilm"
  }'
{"model":"all-minilm"}

After:

curl http://localhost:11434/api/embed \                                 
  -H "Content-Type: application/json" \
  -d '{
    "input": "",
    "model": "all-minilm"
  }'
{"model":"all-minilm","embeddings":[]}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5713 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 7/16/2024 **Status:** ✅ Merged **Merged:** 7/16/2024 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `jmorganca/embed` --- ### 📝 Commits (2) - [`2f3f1f8`](https://github.com/ollama/ollama/commit/2f3f1f86d1a377adcf8f8c62b87213df2868c1ce) server: return empty slice on empty `/api/embed` request - [`67ae410`](https://github.com/ollama/ollama/commit/67ae410efdf2b53d02b750e41211cba80680828f) fix tests ### 📊 Changes **2 files changed** (+7 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+1 -1) 📝 `server/routes_test.go` (+6 -2) </details> ### 📄 Description Before: ``` curl http://localhost:11434/api/embed \ -H "Content-Type: application/json" \ -d '{ "input": "", "model": "all-minilm" }' {"model":"all-minilm"} ``` After: ``` curl http://localhost:11434/api/embed \ -H "Content-Type: application/json" \ -d '{ "input": "", "model": "all-minilm" }' {"model":"all-minilm","embeddings":[]} ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:42:04 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11897
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?