github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 08:30:05 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #5705] [MERGED] Enable windows error dialog for subprocess #11892

New Issue
Closed
opened 2026-04-12 23:41:58 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:41:58 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5705
Author: @dhiltgen
Created: 7/15/2024
Status: ✅ Merged
Merged: 7/26/2024
Merged by: @dhiltgen

Base: main ← Head: win_errormode

📝 Commits (1)

  • e12fff8 Enable windows error dialog for subprocess startup

📊 Changes

6 files changed (+32 additions, -2 deletions)

View changed files

📝 llm/ext_server/server.cpp (+4 -0)
📝 llm/llm_darwin_amd64.go (+3 -0)
📝 llm/llm_darwin_arm64.go (+3 -0)
📝 llm/llm_linux.go (+6 -1)
📝 llm/llm_windows.go (+15 -1)
📝 llm/server.go (+1 -0)

📄 Description

Make sure if something goes wrong spawning the process, the user gets
enough info to be able to try to self correct, or at least file a bug
with details so we can fix it. Once the process starts, we immediately
change back to the recommended setting to prevent the blocking dialog.
This ensures if the model fails to load (OOM, unsupported model type,
etc.) the process will exit quickly and we can scan the stdout/stderr
of the subprocess for the reason to report via API.

Example when I remove the ggml.dll side-band and try to run a model

Screenshot 2024-07-15 at 9 19 13 AM

Note: ollama will be ~stuck until the user clicks the OK button as the subprocess is paused but doesn't exit until they acknowledge, and depending on the nature of the problem, they'll likely get the dialog ~2 times as we attempt fallback runners. If they didn't click the button within our startup timeout (currently 5min) we'd eventually timeout the model load.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5705 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 7/15/2024 **Status:** ✅ Merged **Merged:** 7/26/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `win_errormode` --- ### 📝 Commits (1) - [`e12fff8`](https://github.com/ollama/ollama/commit/e12fff8810e37bfabe4416f7f41902387ff3aae1) Enable windows error dialog for subprocess startup ### 📊 Changes **6 files changed** (+32 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `llm/ext_server/server.cpp` (+4 -0) 📝 `llm/llm_darwin_amd64.go` (+3 -0) 📝 `llm/llm_darwin_arm64.go` (+3 -0) 📝 `llm/llm_linux.go` (+6 -1) 📝 `llm/llm_windows.go` (+15 -1) 📝 `llm/server.go` (+1 -0) </details> ### 📄 Description Make sure if something goes wrong spawning the process, the user gets enough info to be able to try to self correct, or at least file a bug with details so we can fix it. Once the process starts, we immediately change back to the recommended setting to prevent the blocking dialog. This ensures if the model fails to load (OOM, unsupported model type, etc.) the process will exit quickly and we can scan the stdout/stderr of the subprocess for the reason to report via API. Example when I remove the `ggml.dll` side-band and try to run a model ![Screenshot 2024-07-15 at 9 19 13 AM](https://github.com/user-attachments/assets/307a60fa-fb07-4c53-bfec-fd4e400961cb) Note: ollama will be ~stuck until the user clicks the OK button as the subprocess is paused but doesn't exit until they acknowledge, and depending on the nature of the problem, they'll likely get the dialog ~2 times as we attempt fallback runners. If they didn't click the button within our startup timeout (currently 5min) we'd eventually timeout the model load. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:41:58 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?