github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #5205] [MERGED] Fix use_mmap parsing for modelfiles #11712

New Issue
Closed
opened 2026-04-12 23:36:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:36:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5205
Author: @dhiltgen
Created: 6/21/2024
Status: ✅ Merged
Merged: 6/21/2024
Merged by: @dhiltgen

Base: main ← Head: modelfile_use_mmap

📝 Commits (1)

  • 7e77492 Fix use_mmap parsing for modelfiles

📊 Changes

2 files changed (+76 additions, -0 deletions)

View changed files

📝 api/types.go (+13 -0)
📝 api/types_test.go (+63 -0)

📄 Description

Add the new tristate parsing logic for the code path for modelfiles, as well as a unit test.

Fixes #5198

Manually confirmed as well:

% cat use_mmap.modelfile
FROM library/llama2
PARAMETER use_mmap false
% ollama create foo -f ./use_mmap.modelfile
transferring model data
using existing layer sha256:8934d96d3f08982e95922b2b7a2c626a1fe873d7c3b06e8e56d7bc0a1fef9246
using existing layer sha256:8c17c2ebb0ea011be9981cc3922db8ca8fa61e828c5d3f44cb6ae342bf80460b
using existing layer sha256:7c23fb36d80141c4ab8cdbb61ee4790102ebd2bf7aeff414453177d4f2110e5d
using existing layer sha256:2e0493f67d0c8c9c68a8aeacdf6a38a2151cb3c4c1d42accf296e19810527988
using existing layer sha256:fa304d6750612c207b8705aca35391761f29492534e90b30575e4980d6ca82f6
using existing layer sha256:04f36b167ddc372657a153cf129aa32f1f6d5bd4440ce92c5cb4f76f7844417e
writing manifest
success

Where before it would respond with:

% ollama create foo -f ./use_mmap.modelfile
transferring model data
Error: invalid int value [false]

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5205 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 6/21/2024 **Status:** ✅ Merged **Merged:** 6/21/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `modelfile_use_mmap` --- ### 📝 Commits (1) - [`7e77492`](https://github.com/ollama/ollama/commit/7e7749224c57ea4d7ae98e4d07dcb00e192a5c7c) Fix use_mmap parsing for modelfiles ### 📊 Changes **2 files changed** (+76 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+13 -0) 📝 `api/types_test.go` (+63 -0) </details> ### 📄 Description Add the new tristate parsing logic for the code path for modelfiles, as well as a unit test. Fixes #5198 Manually confirmed as well: ``` % cat use_mmap.modelfile FROM library/llama2 PARAMETER use_mmap false % ollama create foo -f ./use_mmap.modelfile transferring model data using existing layer sha256:8934d96d3f08982e95922b2b7a2c626a1fe873d7c3b06e8e56d7bc0a1fef9246 using existing layer sha256:8c17c2ebb0ea011be9981cc3922db8ca8fa61e828c5d3f44cb6ae342bf80460b using existing layer sha256:7c23fb36d80141c4ab8cdbb61ee4790102ebd2bf7aeff414453177d4f2110e5d using existing layer sha256:2e0493f67d0c8c9c68a8aeacdf6a38a2151cb3c4c1d42accf296e19810527988 using existing layer sha256:fa304d6750612c207b8705aca35391761f29492534e90b30575e4980d6ca82f6 using existing layer sha256:04f36b167ddc372657a153cf129aa32f1f6d5bd4440ce92c5cb4f76f7844417e writing manifest success ``` Where before it would respond with: ``` % ollama create foo -f ./use_mmap.modelfile transferring model data Error: invalid int value [false] ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:36:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11712
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?