[PR #5124] [MERGED] Wire up windows AMD driver reporting #11689

Closed
opened 2026-04-12 23:35:57 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/5124
Author: @dhiltgen
Created: 6/18/2024
Status: Merged
Merged: 7/10/2024
Merged by: @dhiltgen

Base: mainHead: amd_windows


📝 Commits (1)

  • 784bf88 Wire up windows AMD driver reporting

📊 Changes

2 files changed (+9 additions, -13 deletions)

View changed files

📝 gpu/amd_hip_windows.go (+2 -3)
📝 gpu/amd_windows.go (+7 -10)

📄 Description

This seems to be ROCm version, not actually driver version, but it may be useful for toggling logic for VRAM reporting in the future

Before:

time=2024-06-18T15:56:19.574-07:00 level=INFO source=types.go:98 msg="inference compute" id=1 library=rocm compute=gfx1100 driver=0.0 name="AMD Radeon RX 7900 XTX" total="24.0 GiB" available="23.9 GiB"

After:

time=2024-06-18T16:15:27.513-07:00 level=INFO source=types.go:98 msg="inference compute" id=1 library=rocm compute=gfx1100 driver=5.7 name="AMD Radeon RX 7900 XTX" total="24.0 GiB" available="23.9 GiB"

fwiw, this version string doesn't seem to be wired to the actual driver version. On this same test system:

Get-WmiObject Win32_VideoController | format-table Name, Description,VideoProcessor,DriverVersion

Name                    Description             VideoProcessor                         DriverVersion
----                    -----------             --------------                         -------------
AMD Radeon(TM) Graphics AMD Radeon(TM) Graphics AMD Radeon Graphics Processor (0x164E) 31.0.24019.1006
AMD Radeon RX 7900 XTX  AMD Radeon RX 7900 XTX  AMD Radeon Graphics Processor (0x744C) 31.0.24019.1006

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/5124 **Author:** [@dhiltgen](https://github.com/dhiltgen) **Created:** 6/18/2024 **Status:** ✅ Merged **Merged:** 7/10/2024 **Merged by:** [@dhiltgen](https://github.com/dhiltgen) **Base:** `main` ← **Head:** `amd_windows` --- ### 📝 Commits (1) - [`784bf88`](https://github.com/ollama/ollama/commit/784bf88b0d0005b771e1bab5adfd6094a3693494) Wire up windows AMD driver reporting ### 📊 Changes **2 files changed** (+9 additions, -13 deletions) <details> <summary>View changed files</summary> 📝 `gpu/amd_hip_windows.go` (+2 -3) 📝 `gpu/amd_windows.go` (+7 -10) </details> ### 📄 Description This seems to be ROCm version, not actually driver version, but it may be useful for toggling logic for VRAM reporting in the future Before: ``` time=2024-06-18T15:56:19.574-07:00 level=INFO source=types.go:98 msg="inference compute" id=1 library=rocm compute=gfx1100 driver=0.0 name="AMD Radeon RX 7900 XTX" total="24.0 GiB" available="23.9 GiB" ``` After: ``` time=2024-06-18T16:15:27.513-07:00 level=INFO source=types.go:98 msg="inference compute" id=1 library=rocm compute=gfx1100 driver=5.7 name="AMD Radeon RX 7900 XTX" total="24.0 GiB" available="23.9 GiB" ``` fwiw, this version string doesn't seem to be wired to the actual driver version. On this same test system: ``` Get-WmiObject Win32_VideoController | format-table Name, Description,VideoProcessor,DriverVersion Name Description VideoProcessor DriverVersion ---- ----------- -------------- ------------- AMD Radeon(TM) Graphics AMD Radeon(TM) Graphics AMD Radeon Graphics Processor (0x164E) 31.0.24019.1006 AMD Radeon RX 7900 XTX AMD Radeon RX 7900 XTX AMD Radeon Graphics Processor (0x744C) 31.0.24019.1006 ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:35:57 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11689