github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-07 00:22:43 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #4842] [MERGED] Separate ListResponse and ModelResponse for api/tags vs api/ps #11598

New Issue
Closed
opened 2026-04-12 23:33:10 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:33:10 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/4842
Author: @royjhan
Created: 6/5/2024
Status: ✅ Merged
Merged: 6/6/2024
Merged by: @royjhan

Base: main ← Head: royh-false-dates

📝 Commits (3)

  • 0b270b5 Remove false time fields
  • ccc6634 Struct Separation for List and Process
  • 03be071 Remove Marshaler

📊 Changes

4 files changed (+30 additions, -14 deletions)

View changed files

📝 api/client.go (+2 -2)
📝 api/types.go (+20 -6)
📝 server/routes.go (+6 -6)
📝 server/routes_test.go (+2 -0)

📄 Description

/api/tags was returning "0001-01-01T00:00:00Z" for 'expires_at'
/api/ps was returning "0001-01-01T00:00:00Z" for 'modified_at'

  • Removes these fields from the respective endpoints

/api/ps was omitting 'size_vram' when it was 0

  • ensures that size_vram is always returned

Added assertion in test case, and tested locally both with curl and CLI

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/4842 **Author:** [@royjhan](https://github.com/royjhan) **Created:** 6/5/2024 **Status:** ✅ Merged **Merged:** 6/6/2024 **Merged by:** [@royjhan](https://github.com/royjhan) **Base:** `main` ← **Head:** `royh-false-dates` --- ### 📝 Commits (3) - [`0b270b5`](https://github.com/ollama/ollama/commit/0b270b5cbf51aeb3d6b789f84ecaaad5d5643028) Remove false time fields - [`ccc6634`](https://github.com/ollama/ollama/commit/ccc6634e4f021e5c6211277d4992e9b42e622ef9) Struct Separation for List and Process - [`03be071`](https://github.com/ollama/ollama/commit/03be071fcf25757b34ad316ad56fe0401fab5346) Remove Marshaler ### 📊 Changes **4 files changed** (+30 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `api/client.go` (+2 -2) 📝 `api/types.go` (+20 -6) 📝 `server/routes.go` (+6 -6) 📝 `server/routes_test.go` (+2 -0) </details> ### 📄 Description /api/tags was returning "0001-01-01T00:00:00Z" for 'expires_at' /api/ps was returning "0001-01-01T00:00:00Z" for 'modified_at' - Removes these fields from the respective endpoints /api/ps was omitting 'size_vram' when it was 0 - ensures that size_vram is always returned Added assertion in test case, and tested locally both with curl and CLI --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:33:10 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?