[PR #4802] [CLOSED] human numbers formats to 3 digits now #11591

Closed
opened 2026-04-12 23:33:00 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/4802
Author: @joshyan1
Created: 6/4/2024
Status: Closed

Base: mainHead: jyan/format


📝 Commits (3)

  • a240ea3 humanNumbers formats to 3 digits, added trillion case for future
  • e21e6b2 added testcase
  • 5dc5a29 added testcase

📊 Changes

2 files changed (+27 additions, -17 deletions)

View changed files

📝 format/format.go (+19 -10)
📝 format/format_test.go (+8 -7)

📄 Description

reformatted humannumbers to always output three digits
added another case for >= trillion

We decided to move these changes to ollama.com to not conflict with current storage.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/4802 **Author:** [@joshyan1](https://github.com/joshyan1) **Created:** 6/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `jyan/format` --- ### 📝 Commits (3) - [`a240ea3`](https://github.com/ollama/ollama/commit/a240ea3367fab5385eaf62f1819054884570cf2e) humanNumbers formats to 3 digits, added trillion case for future - [`e21e6b2`](https://github.com/ollama/ollama/commit/e21e6b2a3389dd57b12f268c005233f7a930af2c) added testcase - [`5dc5a29`](https://github.com/ollama/ollama/commit/5dc5a295bfb93949a8176c15b89eef6e3d0ae82e) added testcase ### 📊 Changes **2 files changed** (+27 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `format/format.go` (+19 -10) 📝 `format/format_test.go` (+8 -7) </details> ### 📄 Description reformatted humannumbers to always output three digits added another case for >= trillion We decided to move these changes to ollama.com to not conflict with current storage. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:33:00 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11591