github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #4570] lint some of the things #11529

New Issue
Closed
opened 2026-04-12 23:31:51 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:31:51 -05:00
Owner
Copy Link

Original Pull Request: https://github.com/ollama/ollama/pull/4570

State: closed
Merged: Yes

now that ollama uses go1.22, x/exp/slices can be replaced with regular slices

enable some useful linters:

  • intrange is a 1.22 feature which simplifies for i := 0; i < n; i++ { } with for i := range n { }
  • testifylint to find bad testify assertions
  • unconvert to find unnecessary type conversions
  • usestdlibvars to find values that can be replaced with stdlib vars, e.g. OPTIONS with http.MethodOptions
  • wastedassign to find unnecessary assignments
  • whitespace is find unnecessary line
**Original Pull Request:** https://github.com/ollama/ollama/pull/4570 **State:** closed **Merged:** Yes --- now that ollama uses go1.22, `x/exp/slices` can be replaced with regular `slices` enable some useful linters: - intrange is a 1.22 feature which simplifies `for i := 0; i < n; i++ { }` with `for i := range n { }` - testifylint to find bad testify assertions - unconvert to find unnecessary type conversions - ~usestdlibvars to find values that can be replaced with stdlib vars, e.g. `OPTIONS` with `http.MethodOptions`~ - wastedassign to find unnecessary assignments - whitespace is find unnecessary line
GiteaMirror added the pull-request label 2026-04-12 23:31:51 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#11529
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?