github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-06 16:11:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #2480] [MERGED] Fix negative keep_alive #10905

New Issue
Closed
opened 2026-04-12 23:15:00 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:15:00 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/2480
Author: @bnorick
Created: 2/13/2024
Status: ✅ Merged
Merged: 2/13/2024
Merged by: @jmorganca

Base: main ← Head: fix_keep_alive

📝 Commits (1)

📊 Changes

1 file changed (+2 additions, -4 deletions)

View changed files

📝 api/types.go (+2 -4)

📄 Description

Using a negative keep_alive did not work as expected, models would unload instantly. Some logging of the duration which was unmarshalled showed that the math.MaxFloat64 was resulting in a very large negative duration rather than the desired very large positive duration.

I just changed these codepaths to use math.MaxInt64, which is what I understand time.Duration to expect.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/2480 **Author:** [@bnorick](https://github.com/bnorick) **Created:** 2/13/2024 **Status:** ✅ Merged **Merged:** 2/13/2024 **Merged by:** [@jmorganca](https://github.com/jmorganca) **Base:** `main` ← **Head:** `fix_keep_alive` --- ### 📝 Commits (1) - [`83c5526`](https://github.com/ollama/ollama/commit/83c552622637e8df0772eaecc4a307a841dd3510) Fix infinite keep_alive ### 📊 Changes **1 file changed** (+2 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `api/types.go` (+2 -4) </details> ### 📄 Description Using a negative `keep_alive` did not work as expected, models would unload instantly. Some logging of the duration which was unmarshalled showed that the `math.MaxFloat64` was resulting in a very large negative duration rather than the desired very large positive duration. I just changed these codepaths to use `math.MaxInt64`, which is what I understand `time.Duration` to expect. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:15:00 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#10905
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?