[PR #2060] [MERGED] fix show handler #10774

Closed
opened 2026-04-12 23:10:23 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/2060
Author: @mxyng
Created: 1/18/2024
Status: Merged
Merged: 1/19/2024
Merged by: @mxyng

Base: mainHead: mxyng/fix-show


📝 Commits (1)

📊 Changes

1 file changed (+3 additions, -4 deletions)

View changed files

📝 server/routes.go (+3 -4)

📄 Description

the show handler is unique in the sense that the request struct is passed directly to GetModel while every other handler deconstructs the request into its parameters. therefore the pattern of setting a local variable model and setting it to req.Model or req.Name doesn't work


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/2060 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 1/18/2024 **Status:** ✅ Merged **Merged:** 1/19/2024 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/fix-show` --- ### 📝 Commits (1) - [`aac9ab4`](https://github.com/ollama/ollama/commit/aac9ab4db756b999c6c95b1159fc357a3b7c44b3) fix show handler ### 📊 Changes **1 file changed** (+3 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+3 -4) </details> ### 📄 Description the show handler is unique in the sense that the request struct is passed directly to `GetModel` while every other handler deconstructs the request into its parameters. therefore the pattern of setting a local variable `model` and setting it to req.Model or req.Name doesn't work --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:10:23 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#10774