github-starred/ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-05-08 00:51:34 -05:00
Code Issues 14.5k Packages Projects Releases 120 Wiki Activity

[PR #1970] [CLOSED] feat: add flag for specifying port number #10742

New Issue
Closed
opened 2026-04-12 23:09:21 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-12 23:09:21 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/1970
Author: @P3rtang
Created: 1/12/2024
Status: ❌ Closed

Base: main ← Head: port-flag

📝 Commits (1)

  • 61cd7dc feat: add flag for specifying port number

📊 Changes

4 files changed (+41 additions, -17 deletions)

View changed files

📝 api/client.go (+6 -1)
📝 api/client_test.go (+4 -2)
📝 cmd/cmd.go (+29 -12)
📝 cmd/interactive.go (+2 -2)

📄 Description

I haven't opened an issue about this since it is already possible to change to default port ollama uses with an env variable.
But it would be more convenient in my opinion to have the port a flag as well. Mostly because I often end up running two instances of ollama, one with gpu acceleration and one without.

The thing I'm most unsure about is having to modify the ClientFromEnvironment function to accept the cobra cmd to get out the port flag variable (this might be the very reason it's done only via the env variable)

This is more of a concept pull request and would love an opinion on this idea

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/1970 **Author:** [@P3rtang](https://github.com/P3rtang) **Created:** 1/12/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `port-flag` --- ### 📝 Commits (1) - [`61cd7dc`](https://github.com/ollama/ollama/commit/61cd7dc6aa94d61b1d4277347c42a4d195701610) feat: add flag for specifying port number ### 📊 Changes **4 files changed** (+41 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `api/client.go` (+6 -1) 📝 `api/client_test.go` (+4 -2) 📝 `cmd/cmd.go` (+29 -12) 📝 `cmd/interactive.go` (+2 -2) </details> ### 📄 Description I haven't opened an issue about this since it is already possible to change to default port ollama uses with an env variable. But it would be more convenient in my opinion to have the port a flag as well. Mostly because I often end up running two instances of ollama, one with gpu acceleration and one without. The thing I'm most unsure about is having to modify the ```ClientFromEnvironment``` function to accept the cobra cmd to get out the port flag variable (this might be the very reason it's done only via the env variable) This is more of a concept pull request and would love an opinion on this idea --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-12 23:09:21 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
cloud
compatibility
context-length
create
docker
documentation
embeddings
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
image
install
intel
js
launch
linux
macos
memory
mlx
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
vulkan
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama#10742
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?