Commit Graph
25 Commits
Author SHA1 Message Date
Daniel HiltgenandGitHub c053d1e985 MLX: make Qwen3.8 Flash Next memory efficient (#18078)
* MLX: reduce Qwen3.8 Flash Next memory use

For NVFP4 creation, retain source precision for sensitive QSA projections
and non-expert MTP weights. Keep routed experts and PLE at NVFP4, and
promote other eligible weights to MXFP8.

Keep NVFP4 PLE tables host-backed, transferring only selected packed rows
and their scales to MLX. Honor scalar and per-expert NVFP4 global scales
in MoE, and per-shard global scales in host-backed PLE.

Use compressed QSA block selections in fused indexed Metal attention for
long prefill batches, retaining the graph fallback. Co-locate component
loading and forward methods, with explicit quantization and cache ownership.

* mlx: skip materializing host-backed tensors

Let models exclude tensors already owned by host storage from MLX loading.
Avoid allocating and discarding the full Qwen PLE tables at startup while
preserving the resident fallback.

* address comments
2026-11-06 13:39:21 -08:00
Daniel HiltgenandGitHub 2e7b870fbc mlx: reject unsupported CUDA devices (#19521)
* mlx: bump for CUDA architecture metadata

* mlx: reject unsupported CUDA devices

* address comments
2026-11-04 09:57:25 -08:00
Daniel HiltgenandGitHub ddf22489b6 mlx: load bundled CUDA libraries in-process on Linux (#19433)
NVIDIA's libcusolver looks for its dependencies only in its own
directory, so libcublas and libnvJitLink resolved to the host's copies
and MLX failed to load when those didn't match the bundled ones. Preload
the bundled copies by full path before loading MLX.
2026-11-03 06:45:30 -08:00
Daniel HiltgenandGitHub 4d22e65d49 mlx: sort long top-k rows in chunks (#19392)
MLX's argpartition sorts the whole row, and a row longer than one block
of the GPU sort takes a multi-pass merge sort. TopKIndices sorts each
2048-value chunk in a single block, then only the chunks' top k, and
returns the same indices in the same order.

The sampler's top_k and top_logprobs and the DFlash2 candidate selector
use it in place of a full-vocabulary argpartition.
2026-10-29 18:53:49 -07:00
Daniel HiltgenandGitHub 66ab8482e0 MLX, MLX-C: version bump - prompt speed up for gemma/flint/laguna (#19291)
* MLX, MLX-C: version bump

The MLX-C pin now provides its own bindings for gather_qmm global_scale
and fast::gated_delta_update, so those two carried patches drop out.
Carry 0001-mlx-c-sdpa-window-size instead: sliding-window attention
added a window_size argument to fast::scaled_dot_product_attention
(ml-explore/mlx#4734) that MLX-C has not bound yet, to be regenerated
from MLX-C once the upstream binding PR merges. The SDPA wrappers gain
a window size argument; all call sites default to the full context.

* mlxrunner: dispatch sliding-window prefills to the native SDPA window

Sliding layers no longer materialize a causal∩sliding mask for prefill
chunks past the window: resolve() dispatches {causal, window} natively
when the rotating cache's L>1 concat has linearized the ring and the
mask is otherwise pure causal, via a new MaskApplier.NativeWindow hint.
Vision relaxations, padding, model arrays, and decode keep the
materialized path. No model changes; sinks compose natively.
2026-10-25 21:25:58 -07:00
Daniel HiltgenandGitHub f580b5484a mlx: add Flint model support (#19181)
Preserve source tool JSON alongside decoded API values so Flint can retain
numeric types and schema order in prompts. Existing API marshaling is unchanged.

Assemble ModelOpt expert banks during safetensors import, and reject direct
Flint NVFP4 creation before conversion. Other models retain their existing
import and quantization paths.

Add optional learned sinks and device causal masks to shared MLX attention.
Existing callers retain the no-sink and host-mask paths; Flint opts into the
new behavior.
2026-10-21 07:45:50 -07:00
Daniel HiltgenandGitHub 2cd63f7a15 mlx: deduplicate CUDA runtime payloads (#17956)
* Deduplicate MLX CUDA runtime payloads

Move CUDA libraries shared by the GGML and MLX backends into the sibling CUDA payload, and teach in-process and subprocess MLX loading to resolve that packaged dependency directory.

Keep MLX-private libraries and JIT headers in the MLX overlay, include the full OpenBLAS Fortran runtime closure, and verify those dependencies in release packaging.

* address comments
2026-10-20 14:15:15 -07:00
Daniel HiltgenandGitHub 00bef57a9f New model... (#19030)
* ci: shorten Windows Vulkan build path

Keep the nested shader-generator compiler probes below Windows path limits in checkouts with longer repository names.

* mlx: fix Nemotron bugs and support global scales

Accept published Nemotron layer names while retaining legacy aliases, and
fix layer-count inference and detached MTP quantization. Stabilize Mamba
softplus, preserve FP32 vision normalization, and compile Mamba gate and
norm scaling.

Support per-expert F32 global scales and preserve activation-scale
companions in ModelOpt and compressed-tensors NVFP4 imports. Normalize
reciprocal globals and reject invalid scales. Keep activation scales
separate from weight-only inference.

* mlx: add Nemotron 3.5 Super

* minor adjustments
2026-10-15 07:28:26 -07:00
Daniel HiltgenandGitHub 292d7ce58c MLX: version bump (#18993) 2026-10-14 11:27:53 -07:00
Daniel HiltgenandGitHub 63b4f61ca9 mlx: port the Metal custom kernels to CUDA (#18657)
* mlx: port the Metal custom kernels to CUDA

mamba2_scan, depthwise_conv_silu and gated_delta (plus their _states/_bias
variants) had a Metal source only, so on CUDA each fell back to graph ops.

Deviations from the Metal sources:

- The scan returns early past D: Metal dispatches an exact thread count,
  CUDA rounds the grid up to whole blocks.
- T is dereferenced; CUDA passes inputs by address, Metal scalarizes
  zero-dimensional ones.
- simd_sum becomes a shfl butterfly, and the threadgroup q/k caches become
  per-warp registers: each warp normalizes the row its own lanes consume,
  costing a redundant norm but no shared memory and no barriers.
- The gates and SiLU call MLX's Sigmoid/LogAddExp/Exp instead of restating
  their formulas. Metal cannot: its custom-kernel preamble is metal::utils()
  alone, while CUDA embeds the op headers for nvrtc.

The parity tests now run on Metal and CUDA hosts.  The fused gated-delta
comparison takes a tolerance: the kernel and the graph path reduce in a
different order, so the bf16 output can land one ULP away.

* address comments
2026-10-13 15:12:17 -07:00
Daniel HiltgenandGitHub 665f9e074c Add Kev decision scoring to MLX (#18976)
* Add Kev decision scoring to MLX

Load Kev models with their FP32 decision head and release metadata.
Support System One scoring with shared-state caching and Kev-specific limits.

* address comments
2026-10-12 21:50:41 -07:00
Daniel HiltgenandGitHub 374d97dd0e MLX, MLX-C: version bump (#18956) 2026-10-12 11:01:37 -07:00
Daniel HiltgenandGitHub a5b659e61b mlx: compact restored recurrent state after speculative rollback (#18955)
* mlx: compact restored recurrent state after speculative rollback

Per-token recurrent captures can leave a restored state pointing into a larger buffer. If a request ends before another model step, the live cache retains that buffer even though it accounts for only the selected state.

Track when a restored state may share that backing buffer. At request close, compact marked states in one batch before retaining them in the prefix cache. Clear the marker when a normal model step replaces the state, and cover restoration and buffer detachment in tests.

* address comments
2026-10-12 09:28:22 -07:00
Daniel HiltgenandGitHub cf2a313a29 mlx: drop carried metal residency patch now that it is upstream (#18854) 2026-10-07 15:22:54 -07:00
Daniel HiltgenandGitHub 8a971df3ba mlx: fix patch for recent mlx update (#18812) 2026-10-05 18:15:59 -07:00
Daniel HiltgenandGitHub 18846f8a9b MLX: version bump (#18720)
* MLX: version bump

* add scopes for unit tests to reduce memory usage
2026-10-05 17:41:51 -07:00
Daniel HiltgenandGitHub d9dec1509d Reduce model lookup and MLX decision request overhead (#18806)
* Reduce model lookup and MLX decision request overhead

Avoid decoding unrelated manifests when resolving existing model names.
Reuse small Metal scratch buffers between decision requests, releasing
larger working sets and clearing scratch after scoring errors.

* address comments
2026-10-05 17:34:41 -07:00
Daniel HiltgenandGitHub cf6c9de620 mlx: mitigate high latency after GPU idle (#18807)
Carry the MLX residency-refresh patch and enable it every second in the
runner, preserving explicit environment overrides.

Fixes #18744.
2026-10-05 16:49:32 -07:00
a00d083bb5 mlx: System one support (#18701)
* mlxrunner: restore System One scoring

Carry the MLX implementation and its tests from the original System One
commit. The API/compiler and llama-server implementation already exist on
the release branch, so retain those versions. Adapt the optional model test
to the renamed decision package and its explicit rendering/context setup.

(cherry picked from commit 26e546ddb3)

* Enable MLX System One and add regression coverage

* mlxrunner: add Laya support for System One

Import Laya checkpoints and implement bidirectional decision scoring.

* mlxrunner: release cached buffers after System One scoring

* decision: match Tev1 and Nimble publisher prompt formats

Select Tev1 prompts using renderer metadata and fix JSON formatting, with regression coverage for GGUF and MLX.

* mlx: support Clef and Clef Flash decision models

Add model import, quantization safeguards, and text/image scoring with the Clef joint decision head.

* support vision capabilities for decision models

* Make Clef scoring cancellable between prefill chunks

Preserve joint-head inputs and test cancellation, cleanup, and recovery.

* mlx: separate decision preparation and readout from forward

Let serial and batched scoring share model-owned preparation and readout
without duplicating architecture-specific logic in the runner.

* mlx: add Strands Decider support

* implement caching

---------

Co-authored-by: ParthSareen <parth.sareen@ollama.com>
2026-10-03 13:17:21 -07:00
Daniel HiltgenandGitHub c0f8da35b2 mlx: speed up Qwen 3.8 prompt processing (#18550)
* mlx: speed up Qwen 3.8 prompt processing

Use MLX's gated-delta kernel for long scans and fold dense MLP global scales into SwiGLU.

* address comments
2026-09-22 17:53:23 -07:00
Daniel HiltgenandGitHub 421d74d20e MLX: version bump (#18576)
Plumbs fast::gated_delta_update through a temporary MLX-C patch for now.
2026-09-22 17:13:16 -07:00
Jesse Gross 2e036e7cdf mlx, mlxrunner: move the MLX engine out of x/
The MLX runner is the only Go inference runner left and is no longer
experimental, so its packages leave x/. The bindings become a top-level
mlx package beside the carried patches in mlx/compat, mirroring how
llama/ holds the llama.cpp integration, and the runner becomes mlxrunner
with the architectures nested under the package they implement.
Subpackages move with their parent unless listed.

  x/mlxrunner/mlx            mlx
  x/internal/mlxthread       mlx/mlxthread
  x/internal/mlxthreadtest   mlx/mlxthread/mlxthreadtest
  x/internal/mlxtest         mlx/mlxtest
  x/quant                    mlx/quant
  mlx/compat/*.patch         mlx/compat/mlx-c   (MLX patches go in mlx/compat/mlx)
  x/mlxrunner                mlxrunner
  x/models/nn                mlxrunner/nn
  x/models/<arch>            mlxrunner/model/<arch>
  x/mlxrunner/imports.go     mlxrunner/model/architectures   (new package)
  x/create                   create
  x/safetensors              fs/safetensors
  x/tokenizer                mlxrunner/tokenizer

Every package keeps its name, so the Go changes are the import path
rewrites the moves force, and the CMake, Dockerfile, CI cache keys, drift
check and Darwin payload script follow the new paths. Four edits are not
paths: the runner's blank architecture imports become the package
mlxrunner/model/architectures, so the list to extend for a new model sits
beside the architecture directories; a depguard rule keeps the two test
harnesses out of non-test code, as the x/internal placement used to; the
CI change filter's two entries for the long-deleted x/imagegen/mlx now
name the bindings' CMake project and the carried patches, so a change to
either builds the payload; and the tokenizer parity test reads its
fixtures from its own testdata instead of walking out of x/.

x/server and x/imagegen/manifest stay for the next two commits.
2026-09-16 14:06:08 -07:00
Daniel HiltgenandGitHub f093c6e008 MLX: version bump (#18235)
* MLX: version bump

* mlx: support ModelOpt global scales in MoE models

* address comments

* address comments
2026-09-14 09:49:46 -07:00
Daniel HiltgenandGitHub 3ba380d0be MLX, MLX-C: version bump (#18080)
* MLX, MLX-C: version bump

* resolve comments

* address comments
2026-09-01 16:24:04 -07:00
Daniel HiltgenandGitHub 0bb0925920 mlx update (#17850)
Temporarily carry https://github.com/ml-explore/mlx-c/pull/127
2026-08-19 07:15:11 -07:00