github-starred/ollama-ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2025-12-05 18:46:22 -06:00
Code Issues 2.2k Packages Projects Releases 100 Wiki Activity

[PR #2922] [CLOSED] Corrects documentation for the "stop" option parameter in modeldile.md #9740

New Issue
Closed
opened 2025-11-12 15:13:07 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-12 15:13:07 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/2922
Author: @dezoito
Created: 3/4/2024
Status: ❌ Closed

Base: main ← Head: fix/docs

📝 Commits (2)

  • 740295b Add Community Integration: Ollama Grid Search
  • fcd6334 Corrects the type for the stop options in modelfile.md (Stop should be an array of string)

📊 Changes

2 files changed (+19 additions, -18 deletions)

View changed files

📝 README.md (+1 -0)
📝 docs/modelfile.md (+18 -18)

📄 Description

This PR corrects the type for the "stop" option documented in modelfile.md ("stop" should be an array of string):

As per 7c0167a8f6/api/types.go (L107):

// Options specfied in GenerateRequest, if you add a new option here add it to the API docs also
type Options struct {
	Runner

	// Predict options used at runtime
	NumKeep          int      `json:"num_keep,omitempty"`
	Seed             int      `json:"seed,omitempty"`
	...
	Stop             []string `json:"stop,omitempty"`
}

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/2922 **Author:** [@dezoito](https://github.com/dezoito) **Created:** 3/4/2024 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/docs` --- ### 📝 Commits (2) - [`740295b`](https://github.com/ollama/ollama/commit/740295b124407e2ddf79625306dbb11b64f2f83d) Add Community Integration: Ollama Grid Search - [`fcd6334`](https://github.com/ollama/ollama/commit/fcd633410777fb89c6c29a67423694cb77d4f250) Corrects the type for the stop options in modelfile.md (Stop should be an array of string) ### 📊 Changes **2 files changed** (+19 additions, -18 deletions) <details> <summary>View changed files</summary> 📝 `README.md` (+1 -0) 📝 `docs/modelfile.md` (+18 -18) </details> ### 📄 Description This PR corrects the type for the "stop" option documented in modelfile.md ("stop" should be an array of string): As per https://github.com/ollama/ollama/blob/7c0167a8f6bef322cb78ebf7651083b385e48c8a/api/types.go#L107: ```go // Options specfied in GenerateRequest, if you add a new option here add it to the API docs also type Options struct { Runner // Predict options used at runtime NumKeep int `json:"num_keep,omitempty"` Seed int `json:"seed,omitempty"` ... Stop []string `json:"stop,omitempty"` } ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-12 15:13:07 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
client2
cloud
compatibility
context-length
create
docker
documentation
embeddings
engine
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
install
integration
intel
js
linux
macos
memory
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
python
question
registry
rendering
thinking
tools
top
windows
wsl
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama-ollama#9740
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?