github-starred/ollama-ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2025-12-05 18:46:22 -06:00
Code Issues 2.2k Packages Projects Releases 100 Wiki Activity

[PR #13007] api/client: handle non-json streaming errors #12777

New Issue
Open
opened 2025-11-12 17:06:34 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-12 17:06:34 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/13007
Author: @BruceMacD
Created: 11/8/2025
Status: 🔄 Open

Base: main ← Head: brucemacd/invalid-char-i-err

📝 Commits (3)

  • 7f9dc9d api/client: handle non-json streaming errors
  • 63cc644 Update client_test.go
  • 14d7ed5 non-json response tests for client do

📊 Changes

2 files changed (+76 additions, -11 deletions)

View changed files

📝 api/client.go (+8 -1)
📝 api/client_test.go (+68 -10)

📄 Description

While processing the response stream during a chat or generation if an error is occurred it is parsed and returned to the user. The issue with the existing code is that this assumed the response would be valid JSON, which is not a safe assumption and caused cryptic error messages to be displayed due to parsing failures: invalid character 'i' looking for beginning of value.

This change updates the stream function to return the raw error string if it cant be parsed as JSON. This should help with debugging issues by making sure the actual error reaches the user.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/13007 **Author:** [@BruceMacD](https://github.com/BruceMacD) **Created:** 11/8/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `brucemacd/invalid-char-i-err` --- ### 📝 Commits (3) - [`7f9dc9d`](https://github.com/ollama/ollama/commit/7f9dc9d7088b15423d0d2ff7cfe86f3cddf71ca0) api/client: handle non-json streaming errors - [`63cc644`](https://github.com/ollama/ollama/commit/63cc644f73b40a03c713d8538adc9386b4e51944) Update client_test.go - [`14d7ed5`](https://github.com/ollama/ollama/commit/14d7ed554ad3c639fcf331059d731c12e8f3a351) non-json response tests for client do ### 📊 Changes **2 files changed** (+76 additions, -11 deletions) <details> <summary>View changed files</summary> 📝 `api/client.go` (+8 -1) 📝 `api/client_test.go` (+68 -10) </details> ### 📄 Description While processing the response stream during a chat or generation if an error is occurred it is parsed and returned to the user. The issue with the existing code is that this assumed the response would be valid JSON, which is not a safe assumption and caused cryptic error messages to be displayed due to parsing failures: `invalid character 'i' looking for beginning of value`. This change updates the stream function to return the raw error string if it cant be parsed as JSON. This should help with debugging issues by making sure the actual error reaches the user. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-12 17:06:34 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
client2
cloud
compatibility
context-length
create
docker
documentation
embeddings
engine
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
install
integration
intel
js
linux
macos
memory
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
python
question
registry
rendering
thinking
tools
top
windows
wsl
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama-ollama#12777
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?