github-starred/ollama-ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2025-12-05 18:46:22 -06:00
Code Issues 2.2k Packages Projects Releases 100 Wiki Activity

[PR #12970] parser: add single quote support to unquote function #12754

New Issue
Open
opened 2025-11-12 17:06:06 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-12 17:06:06 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12970
Author: @MyoungHaSong
Created: 11/5/2025
Status: 🔄 Open

Base: main ← Head: add-single-quote-support-parser

📝 Commits (1)

  • 05859c7 parser: add single quote support to unquote function

📊 Changes

2 files changed (+105 additions, -1 deletions)

View changed files

📝 parser/parser.go (+20 -1)
📝 parser/parser_test.go (+85 -0)

📄 Description

Summary

  • Adds support for single quotes (') and triple single quotes (''') in
    the parser's unquote function
  • Matches the existing double quote functionality
  • Resolves TODO comment in parser/parser.go:571

Changes

  • Added single quote handling to unquote function in parser/parser.go
  • Added triple single quote handling for multiline strings
  • Added 10 comprehensive test cases covering various single quote scenarios

Test Coverage

All tests pass including:

  • Single quoted strings
  • Triple single quoted multiline strings
  • Single quotes containing double quotes
  • Empty single quoted strings
  • Error cases for incomplete quotes

Testing

go test ./parser/... -v

All 20 tests in TestParseFileQuoted pass successfully.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12970 **Author:** [@MyoungHaSong](https://github.com/MyoungHaSong) **Created:** 11/5/2025 **Status:** 🔄 Open **Base:** `main` ← **Head:** `add-single-quote-support-parser` --- ### 📝 Commits (1) - [`05859c7`](https://github.com/ollama/ollama/commit/05859c77fd038b86288bf432c7d625789636ca12) parser: add single quote support to unquote function ### 📊 Changes **2 files changed** (+105 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `parser/parser.go` (+20 -1) 📝 `parser/parser_test.go` (+85 -0) </details> ### 📄 Description ## Summary - Adds support for single quotes (`'`) and triple single quotes (`'''`) in the parser's `unquote` function - Matches the existing double quote functionality - Resolves TODO comment in `parser/parser.go:571` ## Changes - Added single quote handling to `unquote` function in `parser/parser.go` - Added triple single quote handling for multiline strings - Added 10 comprehensive test cases covering various single quote scenarios ## Test Coverage All tests pass including: - Single quoted strings - Triple single quoted multiline strings - Single quotes containing double quotes - Empty single quoted strings - Error cases for incomplete quotes ## Testing ```bash go test ./parser/... -v All 20 tests in TestParseFileQuoted pass successfully. ``` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-12 17:06:06 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
client2
cloud
compatibility
context-length
create
docker
documentation
embeddings
engine
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
install
integration
intel
js
linux
macos
memory
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
python
question
registry
rendering
thinking
tools
top
windows
wsl
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama-ollama#12754
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?