github-starred/ollama-ollama
2
0
Fork 0
mirror of https://github.com/ollama/ollama.git synced 2026-03-11 20:23:55 -05:00
Code Issues 2.2k Packages Projects Releases 100 Wiki Activity

[PR #12838] [MERGED] Removing whitespace between Thinking and Content in Qwen3VL #12713

New Issue
Closed
opened 2025-11-12 16:44:40 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-12 16:44:40 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12838
Author: @gr4ceG
Created: 10/29/2025
Status: ✅ Merged
Merged: 10/29/2025
Merged by: @gr4ceG

Base: main ← Head: grace/fix-extra-whitespace-in-parser

📝 Commits (6)

📊 Changes

3 files changed (+553 additions, -17 deletions)

View changed files

📝 model/parsers/qwen3vl.go (+37 -17)
📝 model/parsers/qwen3vl_nonthinking_test.go (+186 -0)
📝 model/parsers/qwen3vl_thinking_test.go (+330 -0)

📄 Description

Remove extra whitespace from between thinking and actual content

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12838 **Author:** [@gr4ceG](https://github.com/gr4ceG) **Created:** 10/29/2025 **Status:** ✅ Merged **Merged:** 10/29/2025 **Merged by:** [@gr4ceG](https://github.com/gr4ceG) **Base:** `main` ← **Head:** `grace/fix-extra-whitespace-in-parser` --- ### 📝 Commits (6) - [`68306be`](https://github.com/ollama/ollama/commit/68306be14a57ad8edd511ac0271c92e3362d26bb) fixing white spaces in parser - [`d298c6e`](https://github.com/ollama/ollama/commit/d298c6e720e993d0818ec8f66ffef2a7af8eab1b) cleanup - [`3baf19c`](https://github.com/ollama/ollama/commit/3baf19cb1694f4a55ae753794691e70032f09547) trimming tool calling fixed - [`dc4ae80`](https://github.com/ollama/ollama/commit/dc4ae80b6d428ea308f422063494c995771b16ba) fix eating whitespace for tools - [`59d72f5`](https://github.com/ollama/ollama/commit/59d72f50404651e73bfbc67dcaafb1366af13d2c) a couple more tests - [`ebe5968`](https://github.com/ollama/ollama/commit/ebe5968e0f5a72fd5784f6bef00aa08b52f85d47) its so robust, its so resilient ### 📊 Changes **3 files changed** (+553 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `model/parsers/qwen3vl.go` (+37 -17) 📝 `model/parsers/qwen3vl_nonthinking_test.go` (+186 -0) 📝 `model/parsers/qwen3vl_thinking_test.go` (+330 -0) </details> ### 📄 Description Remove extra whitespace from between thinking and actual content --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-12 16:44:40 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
amd
api
app
bug
build
cli
client2
cloud
compatibility
context-length
create
docker
documentation
embeddings
engine
feature request
feedback wanted
good first issue
gpt-oss
gpu
harmony
help wanted
install
integration
intel
js
linux
macos
memory
model
needs more info
networking
nvidia
ollama.com
performance
pull-request
Mirrored from GitHub Pull Request
 python
question
registry
rendering
thinking
tools
top
windows
wsl
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama-ollama#12713
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?