[PR #12544] [CLOSED] server: continue to handle gin.H values until they are removed #12604

Closed
opened 2025-11-12 16:40:26 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/12544
Author: @jmorganca
Created: 10/9/2025
Status: Closed

Base: mainHead: jmorganca/gin-h-compat


📝 Commits (1)

  • 4c87a31 server: continue to handle gin.H values until they are removed

📊 Changes

1 file changed (+18 additions, -0 deletions)

View changed files

📝 server/routes.go (+18 -0)

📄 Description

Handlers will send gin.H values with the "error" key set into the streaming channels in ChatHandler and GenerateHandler. This change continues to honor these values until we replace them by actual api.StatusError values or similar.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/12544 **Author:** [@jmorganca](https://github.com/jmorganca) **Created:** 10/9/2025 **Status:** ❌ Closed **Base:** `main` ← **Head:** `jmorganca/gin-h-compat` --- ### 📝 Commits (1) - [`4c87a31`](https://github.com/ollama/ollama/commit/4c87a31cedcc2f8edbdc6ba8352301be8888a29e) server: continue to handle gin.H values until they are removed ### 📊 Changes **1 file changed** (+18 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `server/routes.go` (+18 -0) </details> ### 📄 Description Handlers will send `gin.H` values with the `"error"` key set into the streaming channels in ChatHandler and GenerateHandler. This change continues to honor these values until we replace them by actual `api.StatusError` values or similar. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-12 16:40:26 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama-ollama#12604