[PR #11205] [MERGED] remove extra field attr #12215

Closed
opened 2025-11-12 16:31:13 -06:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/ollama/ollama/pull/11205
Author: @mxyng
Created: 6/26/2025
Status: Merged
Merged: 8/25/2025
Merged by: @mxyng

Base: mainHead: mxyng/cleanup


📝 Commits (1)

📊 Changes

5 files changed (+5 additions, -5 deletions)

View changed files

📝 model/models/gemma3/model.go (+1 -1)
📝 model/models/llama4/model.go (+1 -1)
📝 model/models/mistral3/model.go (+1 -1)
📝 model/models/mllama/model.go (+1 -1)
📝 model/models/qwen25vl/model.go (+1 -1)

📄 Description

the original intent was to use vision as an alternate to the tensor name. since there's now alt, this is now meaningless. if it becomes necessary to add alternative names, it should use alt, e.g. gguf:"v,alt:vision"


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/ollama/ollama/pull/11205 **Author:** [@mxyng](https://github.com/mxyng) **Created:** 6/26/2025 **Status:** ✅ Merged **Merged:** 8/25/2025 **Merged by:** [@mxyng](https://github.com/mxyng) **Base:** `main` ← **Head:** `mxyng/cleanup` --- ### 📝 Commits (1) - [`e9cfa7d`](https://github.com/ollama/ollama/commit/e9cfa7d32d3a388d7d43b1b445a84ce2872ee234) remove extra field attr ### 📊 Changes **5 files changed** (+5 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `model/models/gemma3/model.go` (+1 -1) 📝 `model/models/llama4/model.go` (+1 -1) 📝 `model/models/mistral3/model.go` (+1 -1) 📝 `model/models/mllama/model.go` (+1 -1) 📝 `model/models/qwen25vl/model.go` (+1 -1) </details> ### 📄 Description the original intent was to use `vision` as an alternate to the tensor name. since there's now `alt`, this is now meaningless. if it becomes necessary to add alternative names, it should use `alt`, e.g. `gguf:"v,alt:vision"` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-11-12 16:31:13 -06:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/ollama-ollama#12215