github-starred/newt
2
0
Fork 0
mirror of https://github.com/fosrl/newt.git synced 2026-05-06 07:59:04 -05:00
Code Issues 227 Packages Projects Releases 40 Wiki Activity

[GH-ISSUE #206] [netstack2]: Relaying packet even though lookup fails? #533

New Issue
Closed
opened 2026-04-16 03:31:08 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-16 03:31:08 -05:00
Owner
Copy Link

Originally created by @LaurenceJJones on GitHub (Dec 16, 2025).
Original GitHub issue: https://github.com/fosrl/newt/issues/206

d5e0771094/netstack2/proxy.go (L463-L471)

Hey the above code attempt to resolve the rewrite address either using the ip/cidr notation or by performing a DNS lookup. If parsing fails or dns fails we still relay the packet to the VIP?

Im looking at adding an internal DNS cache since every new connection will perform a dns lookup which adds latency to every request (until a net state is created) which we can perform the lookup for a user, then cache for a TTL.

However, it seems that forwarding even if resolution fails is not correct behavior, asking in case it was intentional?

Originally created by @LaurenceJJones on GitHub (Dec 16, 2025). Original GitHub issue: https://github.com/fosrl/newt/issues/206 https://github.com/fosrl/newt/blob/d5e0771094f8f729b4dda80b6048dd4098f4fec5/netstack2/proxy.go#L463-L471 Hey the above code attempt to resolve the rewrite address either using the ip/cidr notation or by performing a DNS lookup. If parsing fails or dns fails we still relay the packet to the VIP? Im looking at adding an internal DNS cache since every new connection will perform a dns lookup which adds latency to every request (until a net state is created) which we can perform the lookup for a user, then cache for a TTL. However, it seems that forwarding even if resolution fails is not correct behavior, asking in case it was intentional?
GiteaMirror added the stale label 2026-04-16 03:31:08 -05:00
GiteaMirror commented 2026-04-16 03:31:12 -05:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Jan 20, 2026):

This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.

<!-- gh-comment-id:3770622246 --> @github-actions[bot] commented on GitHub (Jan 20, 2026): This issue has been automatically marked as stale due to 14 days of inactivity. It will be closed in 14 days if no further activity occurs.
GiteaMirror commented 2026-04-16 03:31:14 -05:00
Author
Owner
Copy Link

@github-actions[bot] commented on GitHub (Feb 4, 2026):

This issue has been automatically closed due to inactivity. If you believe this is still relevant, please open a new issue with up-to-date information.

<!-- gh-comment-id:3844587503 --> @github-actions[bot] commented on GitHub (Feb 4, 2026): This issue has been automatically closed due to inactivity. If you believe this is still relevant, please open a new issue with up-to-date information.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
enhancement
good first issue
help wanted
Improvement
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
wontfix
No Label stale
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/newt#533
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?