[PR #358] [MERGED] feat(ci): run a go test before we build #4844

New Issue

GiteaMirror · 2026-06-02T02:56:46-05:00

GiteaMirror commented

2026-06-02 02:56:46 -05:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/newt/pull/358
Author: @cwiggs
Created: 5/15/2026
Status: ✅ Merged
Merged: 5/20/2026
Merged by: @oschwartz10612

Base: main ← Head: feat/ci-go-test

📝 Commits (1)

54a13b2 feat(ci): run a go test before we build

📊 Changes

2 files changed (+19 additions, -2 deletions)

View changed files

📝 .github/workflows/test.yml (+14 -0)
📝 Makefile (+5 -2)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

It doesn't look like there are any go tests being automatically ran as part of CI, as a result 1.12.5 broke the tests (Fix for that in https://github.com/fosrl/newt/pull/357)

This PR adds a phony test make target and updates the already existing test workflow that was just doing a go build to now call the test make target before a build happens.

How to test?

Merge to main or dev after merging https://github.com/fosrl/newt/pull/357 (since go tests are broken) and verify that the Github workflow runs without issues.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/newt/pull/358 **Author:** [@cwiggs](https://github.com/cwiggs) **Created:** 5/15/2026 **Status:** ✅ Merged **Merged:** 5/20/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `feat/ci-go-test` --- ### 📝 Commits (1) - [`54a13b2`](https://github.com/fosrl/newt/commit/54a13b268e34cad5496aa67a4966680c67edb245) feat(ci): run a go test before we build ### 📊 Changes **2 files changed** (+19 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/test.yml` (+14 -0) 📝 `Makefile` (+5 -2) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description It doesn't look like there are any go tests being automatically ran as part of CI, as a result 1.12.5 broke the tests (Fix for that in https://github.com/fosrl/newt/pull/357) This PR adds a phony test make target and updates the already existing test workflow that was just doing a go build to now call the test make target before a build happens. ## How to test? Merge to `main` or `dev` after merging https://github.com/fosrl/newt/pull/357 (since go tests are broken) and verify that the Github workflow runs without issues. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-06-02 02:56:46 -05:00

GiteaMirror closed this issue

2026-06-02 02:56:50 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/newt#4844