github-starred/newt
2
0
Fork 0
mirror of https://github.com/fosrl/newt.git synced 2026-03-09 07:12:28 -05:00
Code Issues 21 Packages Projects Releases 25 Wiki Activity

[security] Does the private key need 0644 #47

New Issue
Closed
opened 2025-11-19 07:12:49 -06:00 by GiteaMirror · 2 comments
GiteaMirror commented 2025-11-19 07:12:49 -06:00
Owner
Copy Link

Originally created by @LaurenceJJones on GitHub (Aug 11, 2025).

Originally assigned to: @oschwartz10612 on GitHub.

151d0e38e6/wg/wg.go (L173)

151d0e38e6/wgnetstack/wgnetstack.go (L199)

As the title states 0644 open read access to public/guest which a secret key should primarily be 0600 so only the user or 0640 for user/group has read access. I dont see why a external none defined user should have read access to the private key file unless newt drops permissions to a lower user.

Originally created by @LaurenceJJones on GitHub (Aug 11, 2025). Originally assigned to: @oschwartz10612 on GitHub. https://github.com/fosrl/newt/blob/151d0e38e6b6f63335d9a1023bb8d2da2d3bccb0/wg/wg.go#L173 https://github.com/fosrl/newt/blob/151d0e38e6b6f63335d9a1023bb8d2da2d3bccb0/wgnetstack/wgnetstack.go#L199 As the title states 0644 open read access to public/guest which a secret key should primarily be 0600 so only the user or 0640 for user/group has read access. I dont see why a external none defined user should have read access to the private key file unless newt drops permissions to a lower user.
GiteaMirror commented 2025-11-19 07:12:50 -06:00
Author
Owner
Copy Link

@oschwartz10612 commented on GitHub (Aug 11, 2025):

Good point I think you are right we should make it 0600 as is customary! I dont see a reason not to right now. Docker might get funny but it should always be the same user inside of docker.

@oschwartz10612 commented on GitHub (Aug 11, 2025): Good point I think you are right we should make it 0600 as is customary! I dont see a reason not to right now. Docker might get funny but it should always be the same user inside of docker.
GiteaMirror commented 2025-11-19 07:12:50 -06:00
Author
Owner
Copy Link

@LaurenceJJones commented on GitHub (Aug 11, 2025):

Note you may want to also check gerbil as I think it has the same 0644 writes.

Also thanks for quick response! ❤️

@LaurenceJJones commented on GitHub (Aug 11, 2025): Note you may want to also check gerbil as I think it has the same `0644` writes. Also thanks for quick response! ❤️
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
enhancement
good first issue
help wanted
Improvement
pull-request
Mirrored from GitHub Pull Request
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/newt#47
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?