github-starred/newt
2
0
Fork 0
mirror of https://github.com/fosrl/newt.git synced 2026-11-11 16:33:24 -06:00
Code Issues 713 Packages Projects Releases 47 Wiki Activity

[Feature Request] Make Docker Socket feature protocol aware #35

New Issue
Closed
opened 2025-11-19 07:12:32 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-19 07:12:32 -06:00
Owner
Copy Link
Copy Source

Originally created by @beefstew809 on GitHub (Jun 7, 2025).

I am trying to use the new DOCKER_SOCKET option that was recently released. Instead of exposing /var/run/docker.sock directly, I am using a socket-proxy container (lscr.io/linuxserver/socket-proxy - https://docs.linuxserver.io/images/docker-socket-proxy) to help secure my environment more.

If I set DOCKER_SOCKET=tcp://socket-proxy:2375 then I receive back the log Docker socket check response sent: available=false. Note that socket-proxy is the name of my container. It could be any name or port after the tcp:// portion.

It looks like the code looks specifically for /var/run/docker.sock and that it does not accept TCP protocols (it is specifically looking for unix).

See:

https://github.com/fosrl/newt/blob/50b621f17c5380ff45acd6fb394712ebf6ebd17e/docker/client.go#L52-L59

I think it will be more than just doing a check and accepting TCP in the above function as I see the code is appending unix to the socketPath at https://github.com/fosrl/newt/blob/50b621f17c5380ff45acd6fb394712ebf6ebd17e/docker/client.go#L83

Request: Make the code protocol aware so that security enhancements such as socket-proxy can be used

Thank you for your condsideration and for this awesome project!

Originally created by @beefstew809 on GitHub (Jun 7, 2025). I am trying to use the new `DOCKER_SOCKET` option that was recently released. Instead of exposing `/var/run/docker.sock` directly, I am using a `socket-proxy` container (`lscr.io/linuxserver/socket-proxy` - https://docs.linuxserver.io/images/docker-socket-proxy) to help secure my environment more. If I set `DOCKER_SOCKET=tcp://socket-proxy:2375` then I receive back the log `Docker socket check response sent: available=false`. Note that `socket-proxy` is the name of my container. It could be any name or port after the `tcp://` portion. It looks like the code looks specifically for `/var/run/docker.sock` and that it does not accept TCP protocols (it is specifically looking for unix). See: https://github.com/fosrl/newt/blob/50b621f17c5380ff45acd6fb394712ebf6ebd17e/docker/client.go#L52-L59 I think it will be more than just doing a check and accepting TCP in the above function as I see the code is appending unix to the `socketPath` at https://github.com/fosrl/newt/blob/50b621f17c5380ff45acd6fb394712ebf6ebd17e/docker/client.go#L83 Request: Make the code protocol aware so that security enhancements such as `socket-proxy` can be used Thank you for your condsideration and for this awesome project!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
docker
enhancement
go
good first issue
help wanted
Improvement
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
wontfix
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
GiteaMirror ninjasurge (Kaehlen Rog)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/newt#35