[PR #274] [MERGED] refactor(proxy): cleanup basics - constants, remove dead code, fix de… #1926

New Issue

GiteaMirror · 2026-04-27T22:35:42-05:00

GiteaMirror commented

2026-04-27 22:35:42 -05:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/newt/pull/274
Author: @LaurenceJJones
Created: 3/16/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @oschwartz10612

Base: dev ← Head: refactor/proxy-cleanup-basics

📝 Commits (1)

13448f7 refactor(proxy): cleanup basics - constants, remove dead code, fix deprecated calls

📊 Changes

1 file changed (+15 additions, -20 deletions)

View changed files

📝 proxy/manager.go (+15 -20)

📄 Description

…precated calls

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Add maxUDPPacketSize constant to replace magic number 65507
Remove commented-out code in Stop()
Replace deprecated ne.Temporary() with errors.Is(err, net.ErrClosed)
Use errors.As instead of type assertion for net.Error
Use errors.Is for closed connection checks instead of string matching
Handle closed connection gracefully when reading from UDP target

How to test?

Internal code.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/newt/pull/274 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/16/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `refactor/proxy-cleanup-basics` --- ### 📝 Commits (1) - [`13448f7`](https://github.com/fosrl/newt/commit/13448f76aa134c922c5111c80deccbe1f72bd11c) refactor(proxy): cleanup basics - constants, remove dead code, fix deprecated calls ### 📊 Changes **1 file changed** (+15 additions, -20 deletions) <details> <summary>View changed files</summary> 📝 `proxy/manager.go` (+15 -20) </details> ### 📄 Description …precated calls ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description - Add maxUDPPacketSize constant to replace magic number 65507 - Remove commented-out code in Stop() - Replace deprecated ne.Temporary() with errors.Is(err, net.ErrClosed) - Use errors.As instead of type assertion for net.Error - Use errors.Is for closed connection checks instead of string matching - Handle closed connection gracefully when reading from UDP target ## How to test? Internal code. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-27 22:35:42 -05:00

GiteaMirror closed this issue

2026-04-27 22:35:42 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/newt#1926