[PR #255] refactor(network): migrate net.IP to netip #1910

New Issue

GiteaMirror · 2026-04-27T22:35:19-05:00

GiteaMirror commented

2026-04-27 22:35:19 -05:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/newt/pull/255
Author: @LaurenceJJones
Created: 3/6/2026
Status: 🔄 Open

Base: dev ← Head: migrate-to-netip

📝 Commits (1)

4f23dc3 refactor(network): migrate net.IP to netip across interface/route/holepunch/netstack paths with safer AddrFromSlice validation

📊 Changes

15 files changed (+249 additions, -212 deletions)

View changed files

📝 bind/shared_bind_test.go (+18 -18)
📝 clients/clients.go (+7 -11)
📝 docker/docker.go (+6 -4)
📝 holepunch/holepunch.go (+26 -20)
📝 holepunch/tester.go (+28 -22)
📝 netstack2/handlers.go (+6 -1)
📝 netstack2/proxy.go (+1 -2)
📝 netstack2/tun.go (+30 -8)
📝 network/interface.go (+55 -20)
📝 network/interface_notwindows.go (+2 -2)
📝 network/interface_windows.go (+2 -19)
📝 network/route.go (+30 -16)
📝 network/route_windows.go (+10 -52)
📝 util/util.go (+12 -10)
📝 wgtester/wgtester.go (+16 -7)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Simply migrate from net.ip to netip golang package which has improved code and access methods

How to test?

simply internal only changes.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/newt/pull/255 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/6/2026 **Status:** 🔄 Open **Base:** `dev` ← **Head:** `migrate-to-netip` --- ### 📝 Commits (1) - [`4f23dc3`](https://github.com/fosrl/newt/commit/4f23dc35d09ea53600f6d0cabe07e1ae9d2922c2) refactor(network): migrate net.IP to netip across interface/route/holepunch/netstack paths with safer AddrFromSlice validation ### 📊 Changes **15 files changed** (+249 additions, -212 deletions) <details> <summary>View changed files</summary> 📝 `bind/shared_bind_test.go` (+18 -18) 📝 `clients/clients.go` (+7 -11) 📝 `docker/docker.go` (+6 -4) 📝 `holepunch/holepunch.go` (+26 -20) 📝 `holepunch/tester.go` (+28 -22) 📝 `netstack2/handlers.go` (+6 -1) 📝 `netstack2/proxy.go` (+1 -2) 📝 `netstack2/tun.go` (+30 -8) 📝 `network/interface.go` (+55 -20) 📝 `network/interface_notwindows.go` (+2 -2) 📝 `network/interface_windows.go` (+2 -19) 📝 `network/route.go` (+30 -16) 📝 `network/route_windows.go` (+10 -52) 📝 `util/util.go` (+12 -10) 📝 `wgtester/wgtester.go` (+16 -7) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Simply migrate from net.ip to netip golang package which has improved code and access methods ## How to test? simply internal only changes. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2026-04-27 22:35:19 -05:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/newt#1910