github-starred/newt
2
0
Fork 0
mirror of https://github.com/fosrl/newt.git synced 2026-05-06 07:59:04 -05:00
Code Issues 227 Packages Projects Releases 40 Wiki Activity

[GH-ISSUE #194] Missing testdata/expected_contains.golden file in 1.6.0 relase assets (tar.gz and zip) #1734

New Issue
Closed
opened 2026-04-27 22:25:22 -05:00 by GiteaMirror · 2 comments
GiteaMirror commented 2026-04-27 22:25:22 -05:00
Owner
Copy Link

Originally created by @lafoush on GitHub (Dec 9, 2025).
Original GitHub issue: https://github.com/fosrl/newt/issues/194

Originally assigned to: @marcschaeferger on GitHub.

Describe the Bug

The release assets for 1.6.0:
https://github.com/fosrl/newt/archive/refs/tags/1.6.0.zip and https://github.com/fosrl/newt/archive/refs/tags/1.6.0.tar.gz are lacking the internal/telemetry/testdata/expected_contains.golden file. As a result, tests are failing and some systems like nix can't create a package from the source:

nix-build
[...]
Running phase: checkPhase
--- FAIL: TestMetricsGoldenContains (0.10s)
    telemetry_golden_test.go:60: read golden: open testdata/expected_contains.golden: no such file or directory
FAIL
FAIL    github.com/fosrl/newt/internal/telemetry        0.545s
FAIL
error: Cannot build '/nix/store/g5g698sgwihb0cyiq01n2b6p3z5673fv-newt-1.6.0.drv'.
       Reason: builder failed with exit code 1.
       Output paths:
         /nix/store/phbjpn0h6g1hyf4r29cqw7jg127wvpqp-newt-1.6.0
       Last 25 log lines:
       > source root is source
       > Running phase: patchPhase
       > Running phase: updateAutotoolsGnuConfigScriptsPhase
       > Running phase: configurePhase
       > Running phase: buildPhase
       > Building subPackage .
       > Building subPackage ./docker
       > Building subPackage ./healthcheck
       > Building subPackage ./internal/state
       > Building subPackage ./internal/telemetry
       > Building subPackage ./logger
       > Building subPackage ./network
       > Building subPackage ./proxy
       > Building subPackage ./updates
       > Building subPackage ./websocket
       > Building subPackage ./wg
       > package github.com/fosrl/newt/wg: build constraints exclude all Go files in /nix/var/nix/builds/nix-93381-55916061/source/wg
       > Building subPackage ./wgnetstack
       > Building subPackage ./wgtester
       > Running phase: checkPhase
       > --- FAIL: TestMetricsGoldenContains (0.10s)
       >     telemetry_golden_test.go:60: read golden: open testdata/expected_contains.golden: no such file or directory
       > FAIL
       > FAIL  github.com/fosrl/newt/internal/telemetry        0.545s
       > FAIL
       For full logs, run:
         nix log /nix/store/g5g698sgwihb0cyiq01n2b6p3z5673fv-newt-1.6.0.drv

Environment

  • OS Type & Version: (e.g., Ubuntu 22.04): N/A
  • Pangolin Version: N/A
  • Gerbil Version: N/A
  • Traefik Version: N/A
  • Newt Version: 1.6.0
  • Olm Version: (if applicable): N/A

To Reproduce

curl -o https://github.com/fosrl/newt/archive/refs/tags/1.6.0.zip
unzip 1.6.0.zip
cd newt-1.6.0
go test ./...
?   	github.com/fosrl/newt	[no test files]
?   	github.com/fosrl/newt/docker	[no test files]
?   	github.com/fosrl/newt/healthcheck	[no test files]
?   	github.com/fosrl/newt/internal/state	[no test files]
--- FAIL: TestMetricsGoldenContains (0.10s)
    telemetry_golden_test.go:60: read golden: open testdata/expected_contains.golden: no such file or directory
FAIL
FAIL	github.com/fosrl/newt/internal/telemetry	0.613s
?   	github.com/fosrl/newt/logger	[no test files]
?   	github.com/fosrl/newt/network	[no test files]
?   	github.com/fosrl/newt/proxy	[no test files]
?   	github.com/fosrl/newt/updates	[no test files]
?   	github.com/fosrl/newt/websocket	[no test files]
?   	github.com/fosrl/newt/wgnetstack	[no test files]
?   	github.com/fosrl/newt/wgtester	[no test files]
FAIL

Expected Behavior

Go tests succeed

Originally created by @lafoush on GitHub (Dec 9, 2025). Original GitHub issue: https://github.com/fosrl/newt/issues/194 Originally assigned to: @marcschaeferger on GitHub. ### Describe the Bug The [release assets for 1.6.0](https://github.com/fosrl/newt/releases/tag/1.6.0): https://github.com/fosrl/newt/archive/refs/tags/1.6.0.zip and https://github.com/fosrl/newt/archive/refs/tags/1.6.0.tar.gz are lacking the internal/telemetry/testdata/expected_contains.golden file. As a result, tests are failing and some systems like nix can't create a package from the source: ```sh nix-build [...] Running phase: checkPhase --- FAIL: TestMetricsGoldenContains (0.10s) telemetry_golden_test.go:60: read golden: open testdata/expected_contains.golden: no such file or directory FAIL FAIL github.com/fosrl/newt/internal/telemetry 0.545s FAIL error: Cannot build '/nix/store/g5g698sgwihb0cyiq01n2b6p3z5673fv-newt-1.6.0.drv'. Reason: builder failed with exit code 1. Output paths: /nix/store/phbjpn0h6g1hyf4r29cqw7jg127wvpqp-newt-1.6.0 Last 25 log lines: > source root is source > Running phase: patchPhase > Running phase: updateAutotoolsGnuConfigScriptsPhase > Running phase: configurePhase > Running phase: buildPhase > Building subPackage . > Building subPackage ./docker > Building subPackage ./healthcheck > Building subPackage ./internal/state > Building subPackage ./internal/telemetry > Building subPackage ./logger > Building subPackage ./network > Building subPackage ./proxy > Building subPackage ./updates > Building subPackage ./websocket > Building subPackage ./wg > package github.com/fosrl/newt/wg: build constraints exclude all Go files in /nix/var/nix/builds/nix-93381-55916061/source/wg > Building subPackage ./wgnetstack > Building subPackage ./wgtester > Running phase: checkPhase > --- FAIL: TestMetricsGoldenContains (0.10s) > telemetry_golden_test.go:60: read golden: open testdata/expected_contains.golden: no such file or directory > FAIL > FAIL github.com/fosrl/newt/internal/telemetry 0.545s > FAIL For full logs, run: nix log /nix/store/g5g698sgwihb0cyiq01n2b6p3z5673fv-newt-1.6.0.drv ``` ### Environment - OS Type & Version: (e.g., Ubuntu 22.04): N/A - Pangolin Version: N/A - Gerbil Version: N/A - Traefik Version: N/A - Newt Version: 1.6.0 - Olm Version: (if applicable): N/A ### To Reproduce ``` curl -o https://github.com/fosrl/newt/archive/refs/tags/1.6.0.zip unzip 1.6.0.zip cd newt-1.6.0 go test ./... ? github.com/fosrl/newt [no test files] ? github.com/fosrl/newt/docker [no test files] ? github.com/fosrl/newt/healthcheck [no test files] ? github.com/fosrl/newt/internal/state [no test files] --- FAIL: TestMetricsGoldenContains (0.10s) telemetry_golden_test.go:60: read golden: open testdata/expected_contains.golden: no such file or directory FAIL FAIL github.com/fosrl/newt/internal/telemetry 0.613s ? github.com/fosrl/newt/logger [no test files] ? github.com/fosrl/newt/network [no test files] ? github.com/fosrl/newt/proxy [no test files] ? github.com/fosrl/newt/updates [no test files] ? github.com/fosrl/newt/websocket [no test files] ? github.com/fosrl/newt/wgnetstack [no test files] ? github.com/fosrl/newt/wgtester [no test files] FAIL ``` ### Expected Behavior Go tests succeed
GiteaMirror added the dependencies label 2026-04-27 22:25:22 -05:00
GiteaMirror commented 2026-04-27 22:25:29 -05:00
Author
Owner
Copy Link

@lafoush commented on GitHub (Dec 9, 2025):

Context: I'm trying to bump newt in nix packages: https://github.com/NixOS/nixpkgs/blob/nixos-25.11/pkgs/by-name/fo/fosrl-newt/package.nix

<!-- gh-comment-id:3629776504 --> @lafoush commented on GitHub (Dec 9, 2025): Context: I'm trying to bump newt in nix packages: https://github.com/NixOS/nixpkgs/blob/nixos-25.11/pkgs/by-name/fo/fosrl-newt/package.nix
GiteaMirror commented 2026-04-27 22:25:32 -05:00
Author
Owner
Copy Link

@marcschaeferger commented on GitHub (Dec 9, 2025):

@lafoush Thanks for reporting this! 🙌

This has already been fixed in the 1.7.0-rc.0
release candidate.
We’ll backport the fix to the 1.6.0 codebase and then cut a 1.6.1 non-RC patch release.

For reference, here is the commit from Oct 28 that contains the fix:
7d60240572

It landed shortly after the 1.6.0 release and we(I) simply forgot to ship a patch release for the 1.6 line, sorry about that!

<!-- gh-comment-id:3634402899 --> @marcschaeferger commented on GitHub (Dec 9, 2025): @lafoush Thanks for reporting this! 🙌 This has already been fixed in the [1.7.0-rc.0](https://github.com/fosrl/newt/releases/tag/1.7.0-rc.0) release candidate. We’ll backport the fix to the 1.6.0 codebase and then cut a 1.6.1 non-RC patch release. For reference, here is the commit from Oct 28 that contains the fix: https://github.com/fosrl/newt/commit/7d602405723e6b55c0622fbd28cb885a2aefe18b It landed shortly after the 1.6.0 release and we(I) simply forgot to ship a patch release for the 1.6 line, sorry about that!
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
enhancement
good first issue
help wanted
Improvement
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
wontfix
No Label dependencies
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/newt#1734
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?