github-starred/newt
2
0
Fork 0
mirror of https://github.com/fosrl/newt.git synced 2026-05-06 07:59:04 -05:00
Code Issues 227 Packages Projects Releases 40 Wiki Activity

[PR #280] [MERGED] fix(healthcheck): Support ipv6 healthchecks #1626

New Issue
Closed
opened 2026-04-24 20:09:39 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-24 20:09:39 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/fosrl/newt/pull/280
Author: @LaurenceJJones
Created: 3/18/2026
Status: ✅ Merged
Merged: 3/18/2026
Merged by: @oschwartz10612

Base: dev ← Head: fix/healthcheck-ipv6

📝 Commits (1)

  • 8fda35d fix(healthcheck): Support ipv6 healthchecks

📊 Changes

1 file changed (+6 additions, -3 deletions)

View changed files

📝 healthcheck/healthcheck.go (+6 -3)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description

Currently we are doing fmt.sprintf on hostname and port which will not properly handle ipv6 addresses, instead of changing pangolin to send bracketed address a simply net.join can do this for us since we dont need to parse a formatted string

How to test?

Enabling healthchecks on a ipv6 address will now work as intended.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/newt/pull/280 **Author:** [@LaurenceJJones](https://github.com/LaurenceJJones) **Created:** 3/18/2026 **Status:** ✅ Merged **Merged:** 3/18/2026 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `dev` ← **Head:** `fix/healthcheck-ipv6` --- ### 📝 Commits (1) - [`8fda35d`](https://github.com/fosrl/newt/commit/8fda35db4f2ee08e217ff698a26e3796c80846d3) fix(healthcheck): Support ipv6 healthchecks ### 📊 Changes **1 file changed** (+6 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `healthcheck/healthcheck.go` (+6 -3) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description Currently we are doing fmt.sprintf on hostname and port which will not properly handle ipv6 addresses, instead of changing pangolin to send bracketed address a simply net.join can do this for us since we dont need to parse a formatted string ## How to test? Enabling healthchecks on a ipv6 address will now work as intended. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 20:09:39 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
dependencies
enhancement
good first issue
help wanted
Improvement
needs investigating
pull-request
Mirrored from GitHub Pull Request
 stale
wontfix
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/newt#1626
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?