[PR #169] [MERGED] Fix Github CICD Action and add Improvements #160

New Issue

GiteaMirror · 2025-11-19T07:15:21-06:00

GiteaMirror commented

2025-11-19 07:15:21 -06:00

📋 Pull Request Information

Original PR: https://github.com/fosrl/newt/pull/169
Author: @marcschaeferger
Created: 10/28/2025
Status: ✅ Merged
Merged: 10/29/2025
Merged by: @oschwartz10612

Base: main ← Head: gh-action

📝 Commits (2)

ee3e7d1 Added Improvements for CICD Action
7d60240 testdata: add expected telemetry metrics for connection attempts and events

📊 Changes

2 files changed (+523 additions, -77 deletions)

View changed files

📝 .github/workflows/cicd.yml (+520 -77)
➕ internal/telemetry/testdata/expected_contains.golden (+3 -0)

📄 Description

Community Contribution License Agreement

By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.

Description by Copilot

This pull request adds new telemetry metrics to the expected output for testing. These metrics help ensure that connection attempts, websocket reconnects, and proxy connections are properly tracked and validated in the telemetry system.

Telemetry metrics updates:

Added newt_connection_attempts_total to track total connection attempts.
Added newt_websocket_reconnects_total to track total websocket reconnects.
Added newt_proxy_connections_total to track total proxy connections.

How to test?

See https://github.com/marcschaeferger/copy-newt/actions/runs/18867902725

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/fosrl/newt/pull/169 **Author:** [@marcschaeferger](https://github.com/marcschaeferger) **Created:** 10/28/2025 **Status:** ✅ Merged **Merged:** 10/29/2025 **Merged by:** [@oschwartz10612](https://github.com/oschwartz10612) **Base:** `main` ← **Head:** `gh-action` --- ### 📝 Commits (2) - [`ee3e7d1`](https://github.com/fosrl/newt/commit/ee3e7d1442902b626a0c34c1dd90439b0672a116) Added Improvements for CICD Action - [`7d60240`](https://github.com/fosrl/newt/commit/7d602405723e6b55c0622fbd28cb885a2aefe18b) testdata: add expected telemetry metrics for connection attempts and events ### 📊 Changes **2 files changed** (+523 additions, -77 deletions) <details> <summary>View changed files</summary> 📝 `.github/workflows/cicd.yml` (+520 -77) ➕ `internal/telemetry/testdata/expected_contains.golden` (+3 -0) </details> ### 📄 Description ## Community Contribution License Agreement By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content. ## Description by Copilot This pull request adds new telemetry metrics to the expected output for testing. These metrics help ensure that connection attempts, websocket reconnects, and proxy connections are properly tracked and validated in the telemetry system. Telemetry metrics updates: * Added `newt_connection_attempts_total` to track total connection attempts. * Added `newt_websocket_reconnects_total` to track total websocket reconnects. * Added `newt_proxy_connections_total` to track total proxy connections. ## How to test? See https://github.com/marcschaeferger/copy-newt/actions/runs/18867902725 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-11-19 07:15:21 -06:00

GiteaMirror closed this issue

2025-11-19 07:15:21 -06:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/newt#160