github-starred/n8n
2
0
Fork 0
mirror of https://github.com/n8n-io/n8n.git synced 2025-12-05 19:27:26 -06:00
Code Issues 1.3k Packages Projects Releases 100 Wiki Activity

[PR #22032] ci: Cleanup docker build scripts #22000

New Issue
Open
opened 2025-11-20 06:22:21 -06:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-11-20 06:22:21 -06:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/n8n-io/n8n/pull/22032
Author: @shortstacked
Created: 11/19/2025
Status: 🔄 Open

Base: master ← Head: docker-build-script-cleanup

📝 Commits (6)

  • 8fa4c28 ci: Cleanup docker build scripts
  • bb36fe6 Merge branch 'master' into docker-build-script-cleanup
  • 5191834 Merge branch 'master' into docker-build-script-cleanup
  • 6596b5d Merge branch 'master' into docker-build-script-cleanup
  • fa3d39e Merge branch 'master' into docker-build-script-cleanup
  • 59b0c21 Merge branch 'master' into docker-build-script-cleanup

📊 Changes

4 files changed (+373 additions, -481 deletions)

View changed files

➖ .github/scripts/determine-runners-tags.sh (+0 -119)
➕ .github/scripts/docker/docker-config.mjs (+171 -0)
➕ .github/scripts/docker/docker-tags.mjs (+113 -0)
📝 .github/workflows/docker-build-push.yml (+89 -362)

📄 Description

Summary

Cleans up the docker-build-push.yml, attempts to move as much of the complicated logic out into scripts that can be run and tested locally.

It's split into a "docker-config" script which gets the type of event e.g scheduled, PR etc and sets values based on that and a "docker-tag" script which adds all the required tags for manifest creation to each image.

Related Linear tickets, Github issues, and Community forum posts

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/n8n-io/n8n/pull/22032 **Author:** [@shortstacked](https://github.com/shortstacked) **Created:** 11/19/2025 **Status:** 🔄 Open **Base:** `master` ← **Head:** `docker-build-script-cleanup` --- ### 📝 Commits (6) - [`8fa4c28`](https://github.com/n8n-io/n8n/commit/8fa4c289f6fa3122843fc96fe3a5e3c347b06b67) ci: Cleanup docker build scripts - [`bb36fe6`](https://github.com/n8n-io/n8n/commit/bb36fe60ab7ba613cc57c70943e8b8cc4dbcae0d) Merge branch 'master' into docker-build-script-cleanup - [`5191834`](https://github.com/n8n-io/n8n/commit/5191834b56e24d73f18b099e10493f1b6e1d012f) Merge branch 'master' into docker-build-script-cleanup - [`6596b5d`](https://github.com/n8n-io/n8n/commit/6596b5dfed382293b84a0f7a0705374eff440bdc) Merge branch 'master' into docker-build-script-cleanup - [`fa3d39e`](https://github.com/n8n-io/n8n/commit/fa3d39ef772ef020e73d11b384de2dd9cea9482b) Merge branch 'master' into docker-build-script-cleanup - [`59b0c21`](https://github.com/n8n-io/n8n/commit/59b0c21a040543dbd0d65288e87a44a8e2974407) Merge branch 'master' into docker-build-script-cleanup ### 📊 Changes **4 files changed** (+373 additions, -481 deletions) <details> <summary>View changed files</summary> ➖ `.github/scripts/determine-runners-tags.sh` (+0 -119) ➕ `.github/scripts/docker/docker-config.mjs` (+171 -0) ➕ `.github/scripts/docker/docker-tags.mjs` (+113 -0) 📝 `.github/workflows/docker-build-push.yml` (+89 -362) </details> ### 📄 Description ## Summary Cleans up the docker-build-push.yml, attempts to move as much of the complicated logic out into scripts that can be run and tested locally. It's split into a "docker-config" script which gets the type of event e.g scheduled, PR etc and sets values based on that and a "docker-tag" script which adds all the required tags for manifest creation to each image. ## Related Linear tickets, Github issues, and Community forum posts ## Review / Merge checklist - [ ] PR title and summary are descriptive. ([conventions](../blob/master/.github/pull_request_title_conventions.md)) <!-- **Remember, the title automatically goes into the changelog. Use `(no-changelog)` otherwise.** --> - [ ] [Docs updated](https://github.com/n8n-io/n8n-docs) or follow-up ticket created. - [ ] Tests included. <!-- A bug is not considered fixed, unless a test is added to prevent it from happening again. A feature is not complete without tests. --> - [ ] PR Labeled with `release/backport` (if the PR is an urgent fix that needs to be backported) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-11-20 06:22:21 -06:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Backlog
bug-report
Bump
Bumped
closed:duplicate
closed:enhancement/feature
closed:incomplete-template
closed:info
closed:non-english
closed:support-issue
closed:working-as-expected
Duplicate
in linear
In Review
n8n team
Needs Feedback
Needs Feedback:Unable to reproduce
node/improvement
node/issue
node/new
pull-request
Mirrored from GitHub Pull Request
Released
Stale
status:complete
status:in-linear
status:pending-assignment
status:team-assigned
team:adore
team:ai
team:cats
team:nodes
team:payday
triage:complete
triage:in-progress
triage:needs-info
triage:needs-reproduction
triage:pending
triage:stalled
ui
Upcoming Release
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/n8n#22000
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?