mirror of
https://github.com/moghtech/komodo.git
synced 2026-03-22 06:11:11 -05:00
Gitlab webhook Issue - no signature in headers #93
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/komodo#93
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @seraphblade2010 on GitHub (Oct 17, 2024).
I have deployed a stack via komodo and configured the corresponding webhook on my self-hosted gitlab.
When the webhook is triggered, i get the following problem in komodo-core:
2024-10-17T10:05:28.220794844Z 2024-10-17T10:05:28.220661Z WARN stack_pull_webhook{id="670e5718fa1e3321e9fb8ddc"}: core::listener::github: failed to run stack pull webook for stack 670e5718fa1e3321e9fb8ddc | no signature in headersThe webhook seems to be connecting, gitlab reports an accepted connection as well.
@seraphblade2010 commented on GitHub (Oct 17, 2024):
After reading a bit it seems komodo expects a different structure of the payload?
Is there any way I can correct it in Gitlab using the "Custom webhook template" Option or is this something that needs to be changed in komodo itself?
I hope its the former and I can finally use komodo and replace portainer with it ^^
@lucacri commented on GitHub (Oct 17, 2024):
Same identical problem here, and same goal (replace portainer)
@mbecker20 commented on GitHub (Oct 18, 2024):
I see, the Gitlab api also is different than Github here. The will send your webhook secret in plain text on
X-Gitlab-Token, rather than generate a signature. It looks like Gitlab do have this feature in the pipeline (opened 7 years ago, 1 month they updated in progress) https://gitlab.com/gitlab-org/gitlab/-/issues/19367#note_2064775564Anyways I will have to release a patch to account for the way they currently do it.
@seraphblade2010 commented on GitHub (Oct 18, 2024):
Nice, thanks for the info ^^
Any Idea if the patch could be out the next couple of weeks or if the coding will be more complex / you have other things in the pipeline before then?
@mbecker20 commented on GitHub (Oct 22, 2024):
I just had 1.16.0 in the pipeline. I can release this as patch to 1.16
@mbecker20 commented on GitHub (Oct 24, 2024):
1.16.3 adds support for the Gitlab authentication method.
After upgrading Komodo, you can edit your configured webhook urls on Gitlab side, just change
githubtogitlabin the webhook URL.