mirror of
https://github.com/moghtech/komodo.git
synced 2026-05-05 15:34:09 -05:00
[Feature] secret (variable) UI configuration #843
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: github-starred/komodo#843
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @C0untZero on GitHub (Aug 29, 2024).
At the moment, secrets are only configurable through the core config file.
It would be nice if we could also do this through the UI.
A simple checkbox next to a variable marking it as secret or not would do the trick!
@mbecker20 commented on GitHub (Aug 29, 2024):
Good Idea. Will add this feature "mark Variable as secret", which will cause it to be hidden in UI / Logs, just as the Secrets defined in config file are.
@C0untZero commented on GitHub (Sep 4, 2024):
Maybe the Value field in the UI should be obfuscated with asterisks when variable is marked as secret?
@mbecker20 commented on GitHub (Sep 4, 2024):
Good point. It should only be visible when opening the edit menu, although the API has no choice but to serve the plaintext secret for editing / management by admins. Also note, non-admin users already receive totally obfuscated secret from API, just
########for the value.@mbecker20 commented on GitHub (Sep 4, 2024):
Added this obfuscation in this commit: https://github.com/mbecker20/komodo/commit/a0021d1785606ba7fc9136b8821c4e6bf18c13f7
Will be included in 1.14.0 stable.