github-starred/komodo
2
0
Fork 0
mirror of https://github.com/moghtech/komodo.git synced 2025-12-05 19:17:36 -06:00
Code Issues 258 Packages Projects Releases 10 Wiki Activity

[PR #836] [CLOSED] Implement modern cross-device favicon system #800

New Issue
Closed
opened 2025-10-31 15:22:11 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 15:22:11 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/836
Author: @MP-Tool
Created: 9/10/2025
Status: ❌ Closed

Base: 1.19.4 ← Head: feature/favicon-system

📝 Commits (1)

  • 0b23f13 feat: implement modern cross-device favicon system

📊 Changes

24 files changed (+60 additions, -27 deletions)

View changed files

📝 frontend/index.html (+28 -6)
➖ frontend/public/apple-touch-icon.png (+0 -0)
➖ frontend/public/favicon-96x96.png (+0 -0)
➖ frontend/public/favicon.ico (+0 -0)
➕ frontend/public/favicon/browserconfig.xml (+10 -0)
➕ frontend/public/favicon/favicon-120.png (+0 -0)
➕ frontend/public/favicon/favicon-128.png (+0 -0)
➕ frontend/public/favicon/favicon-144.png (+0 -0)
➕ frontend/public/favicon/favicon-152.png (+0 -0)
➕ frontend/public/favicon/favicon-16.png (+0 -0)
➕ frontend/public/favicon/favicon-167.png (+0 -0)
➕ frontend/public/favicon/favicon-180.png (+0 -0)
➕ frontend/public/favicon/favicon-192.png (+0 -0)
➕ frontend/public/favicon/favicon-256.png (+0 -0)
➕ frontend/public/favicon/favicon-310.png (+0 -0)
➕ frontend/public/favicon/favicon-32.png (+0 -0)
➕ frontend/public/favicon/favicon-48.png (+0 -0)
➕ frontend/public/favicon/favicon-512.png (+0 -0)
➕ frontend/public/favicon/favicon-64.png (+0 -0)
➕ frontend/public/favicon/favicon-96.png (+0 -0)

...and 4 more files

📄 Description

Problem

Komodo currently uses an incomplete favicon implementation with only basic PNG files, lacking proper device compatibility and modern web standards support. Also legacy favicon was inconsistent with current logo.

Solution

Implemented a comprehensive, modern favicon system that provides optimal compatibility across all devices and platforms:

🔥 Essential Browser Support

  • 32×32 PNG - Modern browsers with HD displays
  • 16×16 PNG - Standard browser tabs
  • 32.ico - Legacy browser support (IE11 and older)

📱 iOS Device Optimization

  • 180×180 - iPhone (2025 standard)
  • 152×152 - iPad Standard
  • 167×167 - iPad Pro
  • 120×120 - iPhone (legacy versions)

📲 Progressive Web App (PWA)

  • site.webmanifest - PWA manifest file
  • Integration with existing komodo-192x192.png and komodo-512x512.png
  • Android Chrome PWA optimization

⚙️ Mobile Web App Integration

  • Apple Mobile Web App capable
  • Optimized status bar styling for iOS
  • Theme color integration
  • Windows tile support via browserconfig.xml

🧹 Code Cleanup

  • Removed legacy favicon files (favicon.ico, favicon-96x96.png, apple-touch-icon.png)
  • Migrated from root manifest.json to /favicon/site.webmanifest
  • Clean, well-documented HTML head structure
  • No dynamic JavaScript - pure static asset implementation

Technical Implementation

  • Static Assets Only - No complex theme logic or JavaScript
  • 2025 Web Standards - Following current best practices
  • Cross-Device Compatible - iPhone, iPad, Android, Desktop, Windows
  • PWA Ready - Progressive Web App support included
  • Performance Optimized - Minimal overhead, static file serving

Files Changed

  • ✅ frontend/index.html - Complete favicon head section rewrite
  • ✅ frontend/public/favicon/ - New comprehensive favicon asset collection
  • ✅ frontend/public/favicon/site.webmanifest - PWA manifest
  • ✅ frontend/public/favicon/browserconfig.xml - Windows tile support
  • 🗑️ Removed legacy files: manifest.json, favicon.ico, apple-touch-icon.png

Benefits

  • ✅ Universal Compatibility - Works on all modern devices and browsers
  • ✅ PWA Support - Progressive Web App ready
  • ✅ iOS Optimized - Perfect iPhone and iPad integration
  • ✅ Performance - Static assets, no JavaScript overhead
  • ✅ Maintainable - Clean, documented implementation
  • ✅ Future-Proof - Follows 2025 web standards

Fixes favicon display issues across all devices and establishes a robust foundation for cross-platform compatibility.
Also Fixes #822

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/836 **Author:** [@MP-Tool](https://github.com/MP-Tool) **Created:** 9/10/2025 **Status:** ❌ Closed **Base:** `1.19.4` ← **Head:** `feature/favicon-system` --- ### 📝 Commits (1) - [`0b23f13`](https://github.com/moghtech/komodo/commit/0b23f1379200ec9873326f69ae17da98046ee94a) feat: implement modern cross-device favicon system ### 📊 Changes **24 files changed** (+60 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `frontend/index.html` (+28 -6) ➖ `frontend/public/apple-touch-icon.png` (+0 -0) ➖ `frontend/public/favicon-96x96.png` (+0 -0) ➖ `frontend/public/favicon.ico` (+0 -0) ➕ `frontend/public/favicon/browserconfig.xml` (+10 -0) ➕ `frontend/public/favicon/favicon-120.png` (+0 -0) ➕ `frontend/public/favicon/favicon-128.png` (+0 -0) ➕ `frontend/public/favicon/favicon-144.png` (+0 -0) ➕ `frontend/public/favicon/favicon-152.png` (+0 -0) ➕ `frontend/public/favicon/favicon-16.png` (+0 -0) ➕ `frontend/public/favicon/favicon-167.png` (+0 -0) ➕ `frontend/public/favicon/favicon-180.png` (+0 -0) ➕ `frontend/public/favicon/favicon-192.png` (+0 -0) ➕ `frontend/public/favicon/favicon-256.png` (+0 -0) ➕ `frontend/public/favicon/favicon-310.png` (+0 -0) ➕ `frontend/public/favicon/favicon-32.png` (+0 -0) ➕ `frontend/public/favicon/favicon-48.png` (+0 -0) ➕ `frontend/public/favicon/favicon-512.png` (+0 -0) ➕ `frontend/public/favicon/favicon-64.png` (+0 -0) ➕ `frontend/public/favicon/favicon-96.png` (+0 -0) _...and 4 more files_ </details> ### 📄 Description ## Problem Komodo currently uses an incomplete favicon implementation with only basic PNG files, lacking proper device compatibility and modern web standards support. Also legacy favicon was inconsistent with current logo. ## Solution Implemented a comprehensive, modern favicon system that provides optimal compatibility across all devices and platforms: ### 🔥 **Essential Browser Support** - **32×32 PNG** - Modern browsers with HD displays - **16×16 PNG** - Standard browser tabs - **32.ico** - Legacy browser support (IE11 and older) ### 📱 **iOS Device Optimization** - **180×180** - iPhone (2025 standard) - **152×152** - iPad Standard - **167×167** - iPad Pro - **120×120** - iPhone (legacy versions) ### 📲 **Progressive Web App (PWA)** - **site.webmanifest** - PWA manifest file - Integration with existing komodo-192x192.png and komodo-512x512.png - Android Chrome PWA optimization ### ⚙️ **Mobile Web App Integration** - Apple Mobile Web App capable - Optimized status bar styling for iOS - Theme color integration - Windows tile support via browserconfig.xml ### 🧹 **Code Cleanup** - Removed legacy favicon files (favicon.ico, favicon-96x96.png, apple-touch-icon.png) - Migrated from root manifest.json to /favicon/site.webmanifest - Clean, well-documented HTML head structure - No dynamic JavaScript - pure static asset implementation ## Technical Implementation - **Static Assets Only** - No complex theme logic or JavaScript - **2025 Web Standards** - Following current best practices - **Cross-Device Compatible** - iPhone, iPad, Android, Desktop, Windows - **PWA Ready** - Progressive Web App support included - **Performance Optimized** - Minimal overhead, static file serving ## Files Changed - ✅ `frontend/index.html` - Complete favicon head section rewrite - ✅ `frontend/public/favicon/` - New comprehensive favicon asset collection - ✅ `frontend/public/favicon/site.webmanifest` - PWA manifest - ✅ `frontend/public/favicon/browserconfig.xml` - Windows tile support - 🗑️ Removed legacy files: manifest.json, favicon.ico, apple-touch-icon.png ## Benefits - ✅ **Universal Compatibility** - Works on all modern devices and browsers - ✅ **PWA Support** - Progressive Web App ready - ✅ **iOS Optimized** - Perfect iPhone and iPad integration - ✅ **Performance** - Static assets, no JavaScript overhead - ✅ **Maintainable** - Clean, documented implementation - ✅ **Future-Proof** - Follows 2025 web standards Fixes favicon display issues across all devices and establishes a robust foundation for cross-platform compatibility. Also Fixes #822 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
 label 2025-10-31 15:22:11 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
1.19.0
1.19.1
1.19.2
1.19.3
1.19.4
bug
documentation
done
enhancement
help wanted
info
pull-request
Mirrored from GitHub Pull Request
question
security
seen 👀
setup
thinking 🤔
ui
No Label
pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/komodo#800
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?