[PR #788] [MERGED] Improve login form #786

New Issue

GiteaMirror · 2025-10-31T15:21:47-05:00

GiteaMirror commented

2025-10-31 15:21:47 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/788
Author: @jackra1n
Created: 8/30/2025
Status: ✅ Merged
Merged: 9/1/2025
Merged by: @mbecker20

Base: 1.19.2 ← Head: improve-login-form

📝 Commits (4)

f2548a9 Use proper form for login, add autocomplete and names to input fields
491eb8c Do not return null if loading
9935b1b Remove unused function
dc23c6f Cleanup and streamline

📊 Changes

3 files changed (+39 additions, -47 deletions)

View changed files

📝 frontend/src/components/util.tsx (+0 -18)
📝 frontend/src/pages/login.tsx (+38 -26)
📝 frontend/src/router.tsx (+1 -3)

📄 Description

Solves https://github.com/moghtech/komodo/issues/403
and maybe https://github.com/moghtech/komodo/issues/652 but I couldn't reproduce everything from that issue so unsure. I tested with iOS, safari and bitwarden, protonpass

this PR improves the login page form implementation. Main changes are replacing local state for credentials with native form submission and improving accessability. I also looked at https://www.chromium.org/developers/design-documents/create-amazing-password-forms/ for some tips.

also removed the unused WithLoading component from util.tsx (i couldnt find any other references of it)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/788 **Author:** [@jackra1n](https://github.com/jackra1n) **Created:** 8/30/2025 **Status:** ✅ Merged **Merged:** 9/1/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `1.19.2` ← **Head:** `improve-login-form` --- ### 📝 Commits (4) - [`f2548a9`](https://github.com/moghtech/komodo/commit/f2548a99e7c68b66e7f2ec9468ce1e5a985a81bf) Use proper form for login, add autocomplete and names to input fields - [`491eb8c`](https://github.com/moghtech/komodo/commit/491eb8cd1b2fcdbc0064bd8f61959594444e8aa3) Do not return null if loading - [`9935b1b`](https://github.com/moghtech/komodo/commit/9935b1b1860796c5a7ef47c62925e97835fbb1cf) Remove unused function - [`dc23c6f`](https://github.com/moghtech/komodo/commit/dc23c6feaf120b994ccfffe06150ec7640951e08) Cleanup and streamline ### 📊 Changes **3 files changed** (+39 additions, -47 deletions) <details> <summary>View changed files</summary> 📝 `frontend/src/components/util.tsx` (+0 -18) 📝 `frontend/src/pages/login.tsx` (+38 -26) 📝 `frontend/src/router.tsx` (+1 -3) </details> ### 📄 Description Solves https://github.com/moghtech/komodo/issues/403 and maybe https://github.com/moghtech/komodo/issues/652 but I couldn't reproduce _everything_ from that issue so unsure. I tested with iOS, safari and bitwarden, protonpass this PR improves the login page form implementation. Main changes are replacing local state for credentials with native form submission and improving accessability. I also looked at https://www.chromium.org/developers/design-documents/create-amazing-password-forms/ for some tips. also removed the unused `WithLoading` component from `util.tsx` (i couldnt find any other references of it) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-10-31 15:21:47 -05:00

GiteaMirror closed this issue

2025-10-31 15:21:48 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#786