github-starred/komodo
2
0
Fork 1
mirror of https://github.com/moghtech/komodo.git synced 2026-03-09 07:13:36 -05:00
Code Issues 258 Packages Projects Releases 10 Wiki Activity

[PR #752] [MERGED] Fix: Correct environment variable name for container stats polling rate #777

New Issue
Closed
opened 2025-10-31 15:21:33 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2025-10-31 15:21:33 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/752
Author: @MP-Tool
Created: 8/21/2025
Status: ✅ Merged
Merged: 8/21/2025
Merged by: @mbecker20

Base: main ← Head: fix/docs

📝 Commits (2)

  • cd57911 docs(config): Update environment variable name and default value for container stats polling rate
  • 582a5e4 fix(config): Update default value for container stats polling rate to 30 seconds

📊 Changes

1 file changed (+3 additions, -3 deletions)

View changed files

📝 config/periphery.config.toml (+3 -3)

📄 Description

Fixes #751

Problem

The periphery config documentation incorrectly used PERIPHERY_STATS_POLLING_RATE for both system stats and container stats polling rate configuration, when they should use different environment variables.

Solution

  • Fixed environment variable name from PERIPHERY_STATS_POLLING_RATE to PERIPHERY_CONTAINER_STATS_POLLING_RATE for container stats polling rate
  • Corrected default value documentation from "5-sec" to "30-sec" to match the actual default value in the codebase (default_container_stats_polling_rate function)

Changes

  • Updated config/periphery.config.toml comments to show correct environment variable name
  • Fixed default value documentation to reflect actual code behavior

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/752 **Author:** [@MP-Tool](https://github.com/MP-Tool) **Created:** 8/21/2025 **Status:** ✅ Merged **Merged:** 8/21/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `main` ← **Head:** `fix/docs` --- ### 📝 Commits (2) - [`cd57911`](https://github.com/moghtech/komodo/commit/cd579111ba64598ee52da3bedee223563965bad8) docs(config): Update environment variable name and default value for container stats polling rate - [`582a5e4`](https://github.com/moghtech/komodo/commit/582a5e401baf930ecec5fa77be0ba44d43a33a1c) fix(config): Update default value for container stats polling rate to 30 seconds ### 📊 Changes **1 file changed** (+3 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `config/periphery.config.toml` (+3 -3) </details> ### 📄 Description # Fixes #751 ## Problem The periphery config documentation incorrectly used `PERIPHERY_STATS_POLLING_RATE` for both system stats and container stats polling rate configuration, when they should use different environment variables. ## Solution - Fixed environment variable name from `PERIPHERY_STATS_POLLING_RATE` to `PERIPHERY_CONTAINER_STATS_POLLING_RATE` for container stats polling rate - Corrected default value documentation from "5-sec" to "30-sec" to match the actual default value in the codebase (`default_container_stats_polling_rate` function) ## Changes - Updated `config/periphery.config.toml` comments to show correct environment variable name - Fixed default value documentation to reflect actual code behavior --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 15:21:33 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
1.19.0
1.19.1
1.19.2
1.19.3
1.19.4
bug
documentation
done
enhancement
help wanted
info
pull-request
Mirrored from GitHub Pull Request
 question
security
seen 👀
setup
thinking 🤔
ui
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/komodo#777
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?