mirror of
https://github.com/moghtech/komodo.git
synced 2026-05-07 10:53:18 -05:00
Komodo with Mongo docker deployment in v1.15.0 #75
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @parnic on GitHub (Oct 7, 2024).
My Komodo install went into a restart loop when Watchtower updated it to v1.15.0. It was timing out attempting to connect to the database server which the timeout log reported as
localhost:27017even though I hadKOMODO_MONGO_ADDRESSset tomongo:27017. From looking at the updated docs today, it seems thatKOMODO_MONGO_*has been renamed toKOMODO_DATABASE_*. This is a reasonable change if the variable is meant to support multiple backing database types, but it is a breaking change that doesn't appear to be called out in the release notes, and I assume there's no compatibility layer to allow the old name(s) to work.So: was this change intentional? Was there a way to know about it ahead of time or should the release notes be updated, at least? Semver would usually call for a breaking change to be a new major version bump.
I see the change came from
8dbd8fe035which appears to have attempted to put aliases in place, but those aliases don't seem to be working.If
0600276b43is the fix for this, can we get that pushed out quickly? :)@parnic commented on GitHub (Oct 7, 2024):
Looks like
0600276b43was the fix and v1.15.1 is deployed now. 👍@mbecker20 commented on GitHub (Oct 7, 2024):
Yeah sorry about that, the intention was backwards compatibility, just had to get that patch out.