[PR #405] [MERGED] Make listener address configurable & Add support for IPv6 #734

New Issue

GiteaMirror · 2025-10-31T15:20:20-05:00

GiteaMirror commented

2025-10-31 15:20:20 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/405
Author: @vosdev
Created: 4/11/2025
Status: ✅ Merged
Merged: 4/14/2025
Merged by: @mbecker20

Base: 1.17.1 ← Head: add-ipv6-support

📝 Commits (3)

a7c1ae9 Make listener address configurable
e87fe5a Make listener address configurable for periphery
ce2e257 rename listener_address -> bind_ip

📊 Changes

8 files changed (+47 additions, -5 deletions)

View changed files

📝 bin/core/src/config.rs (+1 -0)
📝 bin/core/src/main.rs (+3 -2)
📝 bin/periphery/src/config.rs (+1 -0)
📝 bin/periphery/src/main.rs (+5 -3)
📝 client/core/rs/src/entities/config/core.rs (+12 -0)
📝 client/core/rs/src/entities/config/periphery.rs (+13 -0)
📝 config/core.config.toml (+6 -0)
📝 config/periphery.config.toml (+6 -0)

📄 Description

This PR makes the listener address configurable for both Core and Periphery through the following env vars:

CORE_LISTENER_ADDRESS
PERIPHERY_LISTENER_ADDRESS

But the main purpose of this PR is to add support for IPv6.

Before:

ss -tulpn | grep 120
tcp   LISTEN 0      1024              0.0.0.0:9120       0.0.0.0:*    users:(("core",pid=4694,fd=13))          
tcp   LISTEN 0      1024              0.0.0.0:8120       0.0.0.0:*    users:(("periphery",pid=4702,fd=10))

After:

ss -tulpn | grep 120
tcp   LISTEN 0      1024                      *:8120             *:*    users:(("periphery",pid=163028,fd=9))    
tcp   LISTEN 0      1024                      *:9120             *:*    users:(("core",pid=163036,fd=15))

Fixes https://github.com/moghtech/komodo/issues/313

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/405 **Author:** [@vosdev](https://github.com/vosdev) **Created:** 4/11/2025 **Status:** ✅ Merged **Merged:** 4/14/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `1.17.1` ← **Head:** `add-ipv6-support` --- ### 📝 Commits (3) - [`a7c1ae9`](https://github.com/moghtech/komodo/commit/a7c1ae9db9af6b7f0aec2588cae110dd7e696a99) Make listener address configurable - [`e87fe5a`](https://github.com/moghtech/komodo/commit/e87fe5a0bec8560b3870bbaa1820b0fdf0ff9020) Make listener address configurable for periphery - [`ce2e257`](https://github.com/moghtech/komodo/commit/ce2e257d2b43bd369526ddce08782eb903db1c03) rename listener_address -> bind_ip ### 📊 Changes **8 files changed** (+47 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `bin/core/src/config.rs` (+1 -0) 📝 `bin/core/src/main.rs` (+3 -2) 📝 `bin/periphery/src/config.rs` (+1 -0) 📝 `bin/periphery/src/main.rs` (+5 -3) 📝 `client/core/rs/src/entities/config/core.rs` (+12 -0) 📝 `client/core/rs/src/entities/config/periphery.rs` (+13 -0) 📝 `config/core.config.toml` (+6 -0) 📝 `config/periphery.config.toml` (+6 -0) </details> ### 📄 Description This PR makes the listener address configurable for both Core and Periphery through the following env vars: `CORE_LISTENER_ADDRESS` `PERIPHERY_LISTENER_ADDRESS` But the main purpose of this PR is to add support for IPv6. Before: ``` ss -tulpn | grep 120 tcp LISTEN 0 1024 0.0.0.0:9120 0.0.0.0:* users:(("core",pid=4694,fd=13)) tcp LISTEN 0 1024 0.0.0.0:8120 0.0.0.0:* users:(("periphery",pid=4702,fd=10)) ``` After: ``` ss -tulpn | grep 120 tcp LISTEN 0 1024 *:8120 *:* users:(("periphery",pid=163028,fd=9)) tcp LISTEN 0 1024 *:9120 *:* users:(("core",pid=163036,fd=15)) ``` Fixes https://github.com/moghtech/komodo/issues/313 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-10-31 15:20:20 -05:00

GiteaMirror closed this issue

2025-10-31 15:20:20 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#734