[PR #385] [MERGED] Fix: The {account} login fails when the name contains '$' sign #729

New Issue

GiteaMirror · 2025-10-31T15:20:10-05:00

GiteaMirror commented

2025-10-31 15:20:10 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/385
Author: @huzky-v
Created: 3/28/2025
Status: ✅ Merged
Merged: 3/29/2025
Merged by: @mbecker20

Base: 1.17.1 ← Head: fix-docker-login-account-$

📝 Commits (1)

b6138a9 Fix for the {account} login fails when the account name contains '$'

📊 Changes

1 file changed (+1 additions, -1 deletions)

View changed files

📝 bin/periphery/src/docker.rs (+1 -1)

📄 Description

Just found a bug about the docker login process.
I tried Harbor as my image storage, their username always generate in the format of: robot$something+username.

I found that I could not set robot$something+username in the Registry Accounts Setting.
It will lead to
Error response from daemon: Get "https://XXX/v2/": unauthorized
After some research, docker login for this kind of username needs to be
docker login XXX --username 'robot$something+username' instead of docker login XXX --username robot$something+username stated in the code (username needs to be single quoted, found that the code are not quoted)

Not sure if normal username will be affected also
Tested in command line, single quoting a normal username on ghcr.io logins fine

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/385 **Author:** [@huzky-v](https://github.com/huzky-v) **Created:** 3/28/2025 **Status:** ✅ Merged **Merged:** 3/29/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `1.17.1` ← **Head:** `fix-docker-login-account-$` --- ### 📝 Commits (1) - [`b6138a9`](https://github.com/moghtech/komodo/commit/b6138a92d55785fd10a294c9bb1ca3371fe9bd5c) Fix for the {account} login fails when the account name contains '$' ### 📊 Changes **1 file changed** (+1 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/periphery/src/docker.rs` (+1 -1) </details> ### 📄 Description Just found a bug about the docker login process. I tried Harbor as my image storage, their username always generate in the format of: `robot$something+username`. I found that I could not set robot$something+username in the Registry Accounts Setting. It will lead to `Error response from daemon: Get "https://XXX/v2/": unauthorized` After some research, docker login for this kind of username needs to be `docker login XXX --username 'robot$something+username'` instead of `docker login XXX --username robot$something+username` stated in the code (username needs to be single quoted, found that the code are not quoted) Not sure if normal username will be affected also Tested in command line, single quoting a normal username on ghcr.io logins fine --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the

pull-request

label 2025-10-31 15:20:10 -05:00

GiteaMirror closed this issue

2025-10-31 15:20:11 -05:00

GiteaMirror referenced this issue

2025-10-31 15:21:14 -05:00

[PR #722] [MERGED] 1.19.0 #766

GiteaMirror referenced this issue

2025-10-31 15:21:16 -05:00

[PR #729] [MERGED] feat(dashboard): display CPU, memory, and disk usage on server cards #767

GiteaMirror referenced this issue