[PR #301] [MERGED] feature: allow docker image text to overflow in table #721

Closed
opened 2025-10-31 15:19:53 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/301
Author: @unsync
Created: 2/9/2025
Status: Merged
Merged: 2/11/2025
Merged by: @mbecker20

Base: 1.17.0Head: feature/preventtableoverflow


📝 Commits (4)

  • a7ba792 feature: allow docker image text to overflow in table
  • a54b81e review: use break-words
  • 3095d1e wip: revert line break in css file
  • 325938e feature: update devcontainer node release

📊 Changes

2 files changed (+2 additions, -2 deletions)

View changed files

📝 .devcontainer/devcontainer.json (+1 -1)
📝 frontend/src/components/util.tsx (+1 -1)

📄 Description

ℹ️ reopen of https://github.com/moghtech/komodo/pull/295

This PR attempt to fix a UI issue on mobile.

Observations

The image of a service is being truncated and makes it unreadable on mobile :

header view

Screenshot 2025-02-07 at 10 23 18

table view

Screenshot 2025-02-07 at 10 23 42

Which is kind of annoying, because you cannot see the actual image name anywhere :)

Proposed changes

The proposed changes can fix that, but i'm not sure it is the best approach:

header view

Screenshot 2025-02-07 at 10 24 40

table view

Screenshot 2025-02-07 at 10 24 59

ℹ️ It was already breaking the text, but only if your image name had a -


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/301 **Author:** [@unsync](https://github.com/unsync) **Created:** 2/9/2025 **Status:** ✅ Merged **Merged:** 2/11/2025 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `1.17.0` ← **Head:** `feature/preventtableoverflow` --- ### 📝 Commits (4) - [`a7ba792`](https://github.com/moghtech/komodo/commit/a7ba7925a076b60f3bad46ee481b4de70e9645a7) feature: allow docker image text to overflow in table - [`a54b81e`](https://github.com/moghtech/komodo/commit/a54b81ea5fc55d124fe132f7f5846dfc4b0cc780) review: use break-words - [`3095d1e`](https://github.com/moghtech/komodo/commit/3095d1e61935a4ea7854dc842bce3b1cd7e91bc2) wip: revert line break in css file - [`325938e`](https://github.com/moghtech/komodo/commit/325938e75b78bcb2d73bac016dd97325f7c0690d) feature: update devcontainer node release ### 📊 Changes **2 files changed** (+2 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `.devcontainer/devcontainer.json` (+1 -1) 📝 `frontend/src/components/util.tsx` (+1 -1) </details> ### 📄 Description ℹ️ reopen of https://github.com/moghtech/komodo/pull/295 This PR attempt to fix a UI issue on mobile. ### Observations The image of a service is being truncated and makes it unreadable on mobile : #### header view <img width="287" alt="Screenshot 2025-02-07 at 10 23 18" src="https://github.com/user-attachments/assets/c7f7f7ab-ad09-4be0-a4b9-93c3f44d2116" /> #### table view <img width="344" alt="Screenshot 2025-02-07 at 10 23 42" src="https://github.com/user-attachments/assets/991d2f87-f07d-4bfd-8cb7-279d65d23866" /> Which is kind of annoying, because you cannot see the actual image name anywhere :) ### Proposed changes The proposed changes can fix that, but i'm not sure it is the best approach: #### header view <img width="322" alt="Screenshot 2025-02-07 at 10 24 40" src="https://github.com/user-attachments/assets/d8cb7b19-31c9-4374-9abd-67b266caf68b" /> #### table view <img width="379" alt="Screenshot 2025-02-07 at 10 24 59" src="https://github.com/user-attachments/assets/0bba4d91-6596-48a9-b2b9-40ab7a03b05f" /> ℹ️ It was already breaking the text, but only if your image name had a `-` --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the
pull-request
label 2025-10-31 15:19:53 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/komodo#721
No description provided.