[PR #229] [MERGED] Network Usage - Ingress Egress per interface and global usage #712

Closed
opened 2025-10-31 15:19:24 -05:00 by GiteaMirror · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/229
Author: @rita7lopes
Created: 12/18/2024
Status: Merged
Merged: 12/21/2024
Merged by: @mbecker20

Base: mainHead: network_dash_fix


📝 Commits (6)

  • b6ae34c Add network io stats
  • 4a9111d change network hashmap to Vector
  • 0d2bc12 adjust all the network_usage_interface to be a vector rather than a hash map
  • 4d40bab PR requested changes applied
  • 9082b6b Change net_ingress_bytes and egress to network_ingress_bytes egress respectively
  • 50d9bb6 final gen-client types

📊 Changes

10 files changed (+273 additions, -72 deletions)

View changed files

📝 bin/core/src/monitor/record.rs (+3 -0)
📝 bin/periphery/src/api/stats.rs (+1 -0)
📝 bin/periphery/src/stats.rs (+36 -1)
📝 client/core/rs/src/entities/stats.rs (+30 -1)
📝 client/core/ts/src/types.ts (+22 -0)
📝 client/periphery/rs/src/api/stats.rs (+1 -3)
📝 frontend/public/client/types.d.ts (+21 -0)
📝 frontend/src/components/resources/server/hooks.ts (+7 -0)
📝 frontend/src/components/resources/server/stat-chart.tsx (+70 -65)
📝 frontend/src/components/resources/server/stats.tsx (+82 -2)

📄 Description

Hello,

I've added to the UI server stats tab the following:

  • Current Network usage, outlined by ingress and egress, with dynamic unit value so that every customer can see it regardless of the traffic amount
  • Network dashboard,
    • scale is dynamic, according to the max amount of traffic (top value is always 1 - 1 MB, 1 KB, 1 GB depending on the max observed)
    • it defaults to show "All" interfaces traffic summed, but the user can select the interface they want to observe and it persists on reload.

I've integrated the above into the implemented logic.

Also, I've tried merging main into my branch but the Dockerfile/deps to build are broken. I tried fixing but I failed. Thus, I used the files from the previous version, which work.

Images/video on the previous PR: https://github.com/mbecker20/komodo/pull/218

WIP: Changing hashmap to vector type


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/229 **Author:** [@rita7lopes](https://github.com/rita7lopes) **Created:** 12/18/2024 **Status:** ✅ Merged **Merged:** 12/21/2024 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `main` ← **Head:** `network_dash_fix` --- ### 📝 Commits (6) - [`b6ae34c`](https://github.com/moghtech/komodo/commit/b6ae34c02890498251aaecbd10db7af1c4f2d4ea) Add network io stats - [`4a9111d`](https://github.com/moghtech/komodo/commit/4a9111d1d702ccb3d14b273553b3176444121420) change network hashmap to Vector - [`0d2bc12`](https://github.com/moghtech/komodo/commit/0d2bc12502b1e6636f5f9405f6ed89ab4de438b3) adjust all the network_usage_interface to be a vector rather than a hash map - [`4d40bab`](https://github.com/moghtech/komodo/commit/4d40bab34646f3ff815edd773f7311f91956bcb9) PR requested changes applied - [`9082b6b`](https://github.com/moghtech/komodo/commit/9082b6b4abbe34f3899e7818b7c3e3cbe877e016) Change net_ingress_bytes and egress to network_ingress_bytes egress respectively - [`50d9bb6`](https://github.com/moghtech/komodo/commit/50d9bb658739737a2dc5da356f68237347f0a97b) final gen-client types ### 📊 Changes **10 files changed** (+273 additions, -72 deletions) <details> <summary>View changed files</summary> 📝 `bin/core/src/monitor/record.rs` (+3 -0) 📝 `bin/periphery/src/api/stats.rs` (+1 -0) 📝 `bin/periphery/src/stats.rs` (+36 -1) 📝 `client/core/rs/src/entities/stats.rs` (+30 -1) 📝 `client/core/ts/src/types.ts` (+22 -0) 📝 `client/periphery/rs/src/api/stats.rs` (+1 -3) 📝 `frontend/public/client/types.d.ts` (+21 -0) 📝 `frontend/src/components/resources/server/hooks.ts` (+7 -0) 📝 `frontend/src/components/resources/server/stat-chart.tsx` (+70 -65) 📝 `frontend/src/components/resources/server/stats.tsx` (+82 -2) </details> ### 📄 Description Hello, I've added to the UI server stats tab the following: - Current Network usage, outlined by ingress and egress, with dynamic unit value so that every customer can see it regardless of the traffic amount - Network dashboard, - scale is dynamic, according to the max amount of traffic (top value is always 1 - 1 MB, 1 KB, 1 GB depending on the max observed) - it defaults to show "All" interfaces traffic summed, but the user can select the interface they want to observe and it persists on reload. I've integrated the above into the implemented logic. Also, I've tried merging main into my branch but the Dockerfile/deps to build are broken. I tried fixing but I failed. Thus, I used the files from the previous version, which work. Images/video on the previous PR: https://github.com/mbecker20/komodo/pull/218 **WIP: Changing hashmap to vector type** --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2025-10-31 15:19:24 -05:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/komodo#712