[PR #167] [MERGED] 1.16.7 #702

New Issue

GiteaMirror · 2025-10-31T15:18:59-05:00

GiteaMirror commented

2025-10-31 15:18:59 -05:00

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/167
Author: @mbecker20
Created: 11/1/2024
Status: ✅ Merged
Merged: 11/1/2024
Merged by: @mbecker20

Base: main ← Head: 1.16.7

📝 Commits (3)

1b149bc 1.16.7
efabde5 increase builder max poll to allow User Data more time to setup periphery
06f3118 rework to KOMODO_OIDC_REDIRECT_HOST

📊 Changes

9 files changed (+54 additions, -40 deletions)

View changed files

📝 Cargo.lock (+12 -12)
📝 Cargo.toml (+1 -1)
📝 bin/core/src/auth/oidc/mod.rs (+13 -7)
📝 bin/core/src/config.rs (+1 -1)
📝 bin/core/src/helpers/builder.rs (+1 -1)
📝 client/core/rs/src/entities/config/core.rs (+14 -10)
📝 client/core/ts/package.json (+1 -1)
📝 compose/compose.env (+3 -2)
📝 config/core.config.toml (+8 -5)

📄 Description

OIDC: If your Komodo Core container reaches your OIDC provider at a different address than your users do from the browser, changes the logic for KOMODO_OIDC_REDIRECT. The variable is now renamed to KOMODO_OIDC_REDIRECT_HOST and should NOT include the path part of the URL (everything after the slash)

Example:

# This address must be reachable from Core container
KOMODO_OIDC_PROVIDER=http://oidc.provider.internal:9000/application/o/komodo/
# The host address reachable by users in browser
KOMODO_OIDC_REDIRECT_HOST=https://oidc.provider.external # Don't include any "path" in the URL.

# Will replace `http://oidc.provider.internal:9000` with `https://oidc.provider.external` in user redirect.

Double the AWS Builder timeout to allow User Data more time to setup.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/167 **Author:** [@mbecker20](https://github.com/mbecker20) **Created:** 11/1/2024 **Status:** ✅ Merged **Merged:** 11/1/2024 **Merged by:** [@mbecker20](https://github.com/mbecker20) **Base:** `main` ← **Head:** `1.16.7` --- ### 📝 Commits (3) - [`1b149bc`](https://github.com/moghtech/komodo/commit/1b149bc16bd6feec4335679721607605683d1c23) 1.16.7 - [`efabde5`](https://github.com/moghtech/komodo/commit/efabde5989b6250929ba984c6b757703024fbfd6) increase builder max poll to allow User Data more time to setup periphery - [`06f3118`](https://github.com/moghtech/komodo/commit/06f3118149ef20205dd8ce85dbe6416ed38d1125) rework to KOMODO_OIDC_REDIRECT_HOST ### 📊 Changes **9 files changed** (+54 additions, -40 deletions) <details> <summary>View changed files</summary> 📝 `Cargo.lock` (+12 -12) 📝 `Cargo.toml` (+1 -1) 📝 `bin/core/src/auth/oidc/mod.rs` (+13 -7) 📝 `bin/core/src/config.rs` (+1 -1) 📝 `bin/core/src/helpers/builder.rs` (+1 -1) 📝 `client/core/rs/src/entities/config/core.rs` (+14 -10) 📝 `client/core/ts/package.json` (+1 -1) 📝 `compose/compose.env` (+3 -2) 📝 `config/core.config.toml` (+8 -5) </details> ### 📄 Description - **OIDC**: If your Komodo Core container reaches your OIDC provider at a different address than your users do from the browser, changes the logic for `KOMODO_OIDC_REDIRECT`. The variable is now renamed to `KOMODO_OIDC_REDIRECT_HOST` and should NOT include the path part of the URL (everything after the slash) - Example: ``` # This address must be reachable from Core container KOMODO_OIDC_PROVIDER=http://oidc.provider.internal:9000/application/o/komodo/ # The host address reachable by users in browser KOMODO_OIDC_REDIRECT_HOST=https://oidc.provider.external # Don't include any "path" in the URL. # Will replace `http://oidc.provider.internal:9000` with `https://oidc.provider.external` in user redirect. ``` - Double the AWS Builder timeout to allow User Data more time to setup. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

GiteaMirror added the pull-request label 2025-10-31 15:18:59 -05:00

GiteaMirror closed this issue

2025-10-31 15:19:00 -05:00

Sign in to join this conversation.

Branches Tags

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: github-starred/komodo#702