github-starred/komodo
2
0
Fork 1
mirror of https://github.com/moghtech/komodo.git synced 2026-05-07 10:53:18 -05:00
Code Issues 3.5k Packages Projects Releases 103 Wiki Activity

[PR #1169] [CLOSED] fix: always serialize empty params in procedure export #6892

New Issue
Closed
opened 2026-04-24 19:53:31 -05:00 by GiteaMirror · 0 comments
GiteaMirror commented 2026-04-24 19:53:31 -05:00
Owner
Copy Link

📋 Pull Request Information

Original PR: https://github.com/moghtech/komodo/pull/1169
Author: @litlmike
Created: 2/8/2026
Status: ❌ Closed

Base: main ← Head: fix-issue-672

📝 Commits (1)

  • 1b3115b fix: always serialize empty params in procedure export

📊 Changes

7 files changed (+17 additions, -1 deletions)

View changed files

📝 bin/core/src/sync/toml.rs (+5 -1)
📝 client/core/rs/src/api/execute/action.rs (+1 -0)
📝 client/core/rs/src/api/execute/build.rs (+1 -0)
📝 client/core/rs/src/api/execute/deployment.rs (+2 -0)
📝 client/core/rs/src/api/execute/procedure.rs (+1 -0)
📝 client/core/rs/src/api/execute/repo.rs (+3 -0)
📝 client/core/rs/src/api/execute/stack.rs (+4 -0)

📄 Description

When serializing procedure stages to TOML, empty string fields (like pattern) were dropped by toml_pretty's skip_empty_string option. This caused params to be empty/missing, failing deserialization with missing field params.

Two fixes:

  1. Disable skip_empty_string when serializing procedure stages so fields like pattern = "" are preserved in TOML output.
  2. Add #[serde(default)] to pattern fields on all Batch* execution structs as defense-in-depth.

Closes #672

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/moghtech/komodo/pull/1169 **Author:** [@litlmike](https://github.com/litlmike) **Created:** 2/8/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix-issue-672` --- ### 📝 Commits (1) - [`1b3115b`](https://github.com/moghtech/komodo/commit/1b3115bd9638cfb47fd54979332df2a3b99246f0) fix: always serialize empty params in procedure export ### 📊 Changes **7 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `bin/core/src/sync/toml.rs` (+5 -1) 📝 `client/core/rs/src/api/execute/action.rs` (+1 -0) 📝 `client/core/rs/src/api/execute/build.rs` (+1 -0) 📝 `client/core/rs/src/api/execute/deployment.rs` (+2 -0) 📝 `client/core/rs/src/api/execute/procedure.rs` (+1 -0) 📝 `client/core/rs/src/api/execute/repo.rs` (+3 -0) 📝 `client/core/rs/src/api/execute/stack.rs` (+4 -0) </details> ### 📄 Description When serializing procedure stages to TOML, empty string fields (like `pattern`) were dropped by toml_pretty's `skip_empty_string` option. This caused params to be empty/missing, failing deserialization with `missing field params`. Two fixes: 1. Disable `skip_empty_string` when serializing procedure stages so fields like `pattern = ""` are preserved in TOML output. 2. Add `#[serde(default)]` to `pattern` fields on all Batch* execution structs as defense-in-depth. Closes #672 --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
GiteaMirror added the pull-request label 2026-04-24 19:53:31 -05:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
1.19.0
1.19.1
1.19.2
1.19.3
1.19.4
2.0.0
bug
documentation
done
enhancement
help wanted
info
pull-request
Mirrored from GitHub Pull Request
 question
security
seen 👀
setup
thinking 🤔
ui
v2
No Label pull-request
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
GiteaMirror ninjasurge
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: github-starred/komodo#6892
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?